From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755175AbYKEWF1 (ORCPT ); Wed, 5 Nov 2008 17:05:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753393AbYKEWFM (ORCPT ); Wed, 5 Nov 2008 17:05:12 -0500 Received: from smtp-out.google.com ([216.239.33.17]:3681 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752107AbYKEWFK (ORCPT ); Wed, 5 Nov 2008 17:05:10 -0500 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type; b=dIDEusDsPliWLvTIut+SR9SV0tE3O/d8tidWdRqtzic8zckEiVS0nOs8P6OMbMV+e /Ko628CS/gyD2ZLzRPOzA== Date: Wed, 5 Nov 2008 14:04:42 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Andrew Morton cc: Christoph Lameter , peterz@infradead.org, npiggin@suse.de, Paul Menage , dfults@sgi.com, linux-kernel@vger.kernel.org, containers@lists.osdl.org, Andrea Righi Subject: Re: [patch 0/7] cpuset writeback throttling In-Reply-To: <20081105125603.36d0c222.akpm@linux-foundation.org> Message-ID: References: <20081104124753.fb1dde5a.akpm@linux-foundation.org> <1225831988.7803.1939.camel@twins> <20081104131637.68fbe055.akpm@linux-foundation.org> <1225833710.7803.1993.camel@twins> <20081104135004.f1717fcf.akpm@linux-foundation.org> <20081104143534.b5c16147.akpm@linux-foundation.org> <20081104153610.bbfd5ed8.akpm@linux-foundation.org> <20081104190505.769b93ec.akpm@linux-foundation.org> <20081105104145.abd6fc91.akpm@linux-foundation.org> <20081105123150.d6628805.akpm@linux-foundation.org> <20081105125603.36d0c222.akpm@linux-foundation.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 Nov 2008, Andrew Morton wrote: > See, here's my problem: we have a pile of new code which fixes some > problem. But the problem seems to be fairly small - it only affects a > small number of sophisticated users and they already have workarounds > in place. > The workarounds, while restrictive of how you configure your cpusets, are indeed effective. > So the world wouldn't end if we just didn't merge it. Those users > stick with their workarounds and the kernel remains simpler and > smaller. > Agreed. This patchset is admittedly from a different time when cpusets was the only relevant extension that needed to be done. > How do we work out which is the best choice here? I don't have enough > information to do this. > If we are to support memcg-specific dirty ratios, that requires the aforementioned statistics to be collected so that the calculation is even possible. The series at http://marc.info/?l=linux-kernel&m=122123225006571 http://marc.info/?l=linux-kernel&m=122123241106902 is a step in that direction, although I'd prefer to see NR_UNSTABLE_NFS to be extracted separately from MEM_CGROUP_STAT_FILE_DIRTY so throttle_vm_writeout() can also use the new statistics.