From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754804AbYKJKDh (ORCPT ); Mon, 10 Nov 2008 05:03:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754146AbYKJKD3 (ORCPT ); Mon, 10 Nov 2008 05:03:29 -0500 Received: from smtp-out.google.com ([216.239.45.13]:8229 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754119AbYKJKD2 (ORCPT ); Mon, 10 Nov 2008 05:03:28 -0500 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type; b=xDqIYLdE27qvijEMMndhB6fpmpjT5MSLIOuKzamb4P6uiyqIIpGpZqd9NHbp3D3KA Wo3anodmZzSnOhLK/DTdA== Date: Mon, 10 Nov 2008 02:02:49 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Andrea Righi cc: KAMEZAWA Hiroyuki , Andrew Morton , Christoph Lameter , peterz@infradead.org, npiggin@suse.de, menage@google.com, dfults@sgi.com, linux-kernel@vger.kernel.org, containers@lists.osdl.org Subject: Re: [patch 0/7] cpuset writeback throttling In-Reply-To: <4917F895.109@gmail.com> Message-ID: References: <20081104124753.fb1dde5a.akpm@linux-foundation.org> <1225831988.7803.1939.camel@twins> <20081104131637.68fbe055.akpm@linux-foundation.org> <1225833710.7803.1993.camel@twins> <20081104135004.f1717fcf.akpm@linux-foundation.org> <20081104143534.b5c16147.akpm@linux-foundation.org> <20081104153610.bbfd5ed8.akpm@linux-foundation.org> <20081104190505.769b93ec.akpm@linux-foundation.org> <20081105133157.db8bae72.kamezawa.hiroyu@jp.fujitsu.com> <4917F895.109@gmail.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Nov 2008, Andrea Righi wrote: > > IIUC, Andrea Righ posted 2 patches around dirty_ratio. (added him to CC:) > > in early October. > > > > (1) patch for adding dirty_ratio_pcm. (1/100000) > > (2) per-memcg dirty ratio. (maybe this..http://lkml.org/lkml/2008/9/12/121) > > > > (1) should be just posted again. > > > > Because we have changed page_cgroup implementation, (2) should be reworked. > > "rework" itself will not be very difficult. > > (.... we tend to be stick to "what interface is the best" discussion ;) > > > > But memcg itself is not so weak against dirty_pages because we don't call > > try_to_free_pages() becasue of memory shortage but because of memory limitation. > > > > BTW, in my current stack, followings are queued. > > a. handle SwapCache in proper way in memcg. > > b. handle swap_cgroup (if configured) > > c. make LRU handling easier > > > > For making per-memcg dirty_ratio sane, (a) should go ahead. I do (a) now. > > If Andrea seems to be too busy, I'll schedule dirty_ratio-for-memcg as my work. > > > > Hi Kame, > > sorry for my late. If it's not too late tonight I'll rebase and test (1) > to 2.6.28-rc2-mm1 and start to rework on (2), also considering the > David's suggestion (split NR_UNSTABLE_NFS from NR_FILE_DIRTY). > The dirty throttling change only depends on patch 1/2 from (2) above, which adds the necessary statistics to the memcg for calculating dirty ratios. Patch 2/2 from that series will need to be moved out to a separate cgroup as the general consensus from this discussion has indicated is necessary. If it's possible to get a rebased patch 1/2 to add the statistics to the memory controller, I'll take it and move the all dirty throttling to a separate cgroup so it supports both cpusets and memcg. Thanks!