From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753807AbZBBIB5 (ORCPT ); Mon, 2 Feb 2009 03:01:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751627AbZBBIBr (ORCPT ); Mon, 2 Feb 2009 03:01:47 -0500 Received: from utopia.booyaka.com ([72.9.107.138]:41556 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071AbZBBIBr (ORCPT ); Mon, 2 Feb 2009 03:01:47 -0500 Date: Mon, 2 Feb 2009 01:01:45 -0700 (MST) From: Paul Walmsley To: Russell King - ARM Linux cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Tony Lindgren Subject: Re: [PATCH F 10/12] OMAP2/3 clock: omap2_clk_enable(): fix logic In-Reply-To: <20090131105848.GC1394@n2100.arm.linux.org.uk> Message-ID: References: <20090128193326.2396.9437.stgit@localhost.localdomain> <20090128193525.2396.11744.stgit@localhost.localdomain> <20090131105848.GC1394@n2100.arm.linux.org.uk> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Russell, On Sat, 31 Jan 2009, Russell King - ARM Linux wrote: > On Wed, Jan 28, 2009 at 12:35:28PM -0700, Paul Walmsley wrote: > > Rearrange the parent clock enable status check code so it actually makes > > sense. No functional change. > > I don't think there's anything gained from introducing the additional > 'parent_ret' variable. I thought it made the code slightly easier to understand; but, am not attached to it. Please let me know if you'd like me to send a version of the patch without it, - Paul