From: Dan Carpenter <error27@gmail.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Cc: Dan Carpenter <error27@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sx.c: fix dbl statement if - add missing braces
Date: Thu, 19 Feb 2009 15:24:17 +0300 (EAT) [thread overview]
Message-ID: <alpine.DEB.2.00.0902191518570.3404@bikeee> (raw)
In-Reply-To: <Pine.LNX.4.64.0902181547110.31742@wrl-59.cs.helsinki.fi>
While we're at it, here is another patch for that file.
The "break" would just result in reusing a free'd pointer. I don't have
the cards myself to test it though. :/
regards,
dan carpenter
Signed-off-by: Dan Carpenter <error27@gmail.com>
--- orig/drivers/char/sx.c 2009-02-19 11:27:51.000000000 +0300
+++ devel/drivers/char/sx.c 2009-02-19 11:29:05.000000000 +0300
@@ -1788,7 +1788,7 @@
nbytes - i : SX_CHUNK_SIZE)) {
kfree(tmp);
rc = -EFAULT;
- break;
+ goto out;
}
memcpy_toio(board->base2 + offset + i, tmp,
(i + SX_CHUNK_SIZE > nbytes) ?
@@ -1845,6 +1845,7 @@
rc = -ENOTTY;
break;
}
+out:
unlock_kernel();
func_exit();
return rc;
prev parent reply other threads:[~2009-02-19 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 13:52 Ilpo Järvinen
2009-02-19 9:55 ` Dan Carpenter
2009-02-19 12:24 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.0902191518570.3404@bikeee \
--to=error27@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®