From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760867AbZBXWcQ (ORCPT ); Tue, 24 Feb 2009 17:32:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756902AbZBXWcA (ORCPT ); Tue, 24 Feb 2009 17:32:00 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:54379 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756005AbZBXWb7 (ORCPT ); Tue, 24 Feb 2009 17:31:59 -0500 Date: Tue, 24 Feb 2009 17:31:56 -0500 (EST) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Masami Hiramatsu cc: Peter Zijlstra , linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Thomas Gleixner , Frederic Weisbecker , Theodore Tso , Arjan van de Ven , Pekka Paalanen , Arnaldo Carvalho de Melo , Jason Baron , Martin Bligh , Mathieu Desnoyers , "Frank Ch. Eigler" , KOSAKI Motohiro , Jens Axboe Subject: Re: [PATCH 0/4][RFC] event tracer In-Reply-To: <49A473ED.4010001@redhat.com> Message-ID: References: <20090224193344.638329210@goodmis.org> <1235504556.4645.2252.camel@laptop> <49A473ED.4010001@redhat.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Feb 2009, Masami Hiramatsu wrote: > > > > #undef TPFMT > > #define TPFMT(fmt, args...) \ > > "(%s)" fmt "\n", #call, ##args > > > > and then I could do > > > > event_printk(fmt); > > Why don't you do as below? :) > event_printk_line("(" #call ")" ##fmtandargs); Still need to sneak that "\n" in ;-) > > Anyway, your proposal is good for me, because it will recover > an information which tracepoint has lost. Thanks, -- Steve