mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing/core: bring back raw trace_printk for dynamic formats strings
Date: Thu, 12 Mar 2009 13:51:30 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.0903121350490.3062@gandalf.stny.rr.com> (raw)
In-Reply-To: <49b94a35.03e9300a.3afc.42cc@mx.google.com>


On Thu, 12 Mar 2009, Frederic Weisbecker wrote:

> Impact: fix callsites with dynamic format strings
> 
> Since its new binary implementation, trace_printk() internally uses static
> containers for the format strings on each callsites.
> But the value is assigned once at build time, which means that it can't take
> dynamic formats.
> 
> So this patch unearthes the raw trace_printk implementation for the callers
> that will need trace_printk to be able to carry these dynamic format strings.
> The trace_printk() macro will use the appropriate implementation for each
> callsite.
> Most of the time however, the binary implementation will still be used.
> 
> The other impact of this patch is that mmiotrace_printk() will use the old
> implementation because it calls the low level trace_vprintk and we can't guess
> here whether the format passed in it is dynamic or not.
> 
> Some parts of this patch have been written by Steven Rostedt (most notably the
> part that chooses the appropriate implementation for each callsites).
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>

Thanks Frederic!

Ingo, I'm going to pull this in my tree, since I have some patches 
dependent on it.

-- Steve

      reply	other threads:[~2009-03-12 17:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-12 17:24 Frederic Weisbecker
2009-03-12 17:51 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.0903121350490.3062@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®