From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762720AbZCYOWI (ORCPT ); Wed, 25 Mar 2009 10:22:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762006AbZCYOSl (ORCPT ); Wed, 25 Mar 2009 10:18:41 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:35555 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762142AbZCYOSk (ORCPT ); Wed, 25 Mar 2009 10:18:40 -0400 Date: Wed, 25 Mar 2009 10:18:37 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: LKML cc: =?ISO-8859-15?Q?Fr=E9d=E9ric_Weisbecker?= , Ingo Molnar , Linus Torvalds , Andrew Morton , Lai Jiangshan Subject: Re: Credit for vsprintk work In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Mar 2009, Steven Rostedt wrote: > > Frederic, > > $ git blame lib/vsprintf.c |grep 'Frederic Weisbecker' | wc -l > 542 > > You did a hell of a lot of work on vsprintf.c, and you are still too > modest to put in a copyright at the top. > > I know some people think that git is good enough for ownership. But > really, the amount of changes that you did in vsprintf.c deserves a bit of > credit in the source file. > > Is everyone OK if a copyright goes at the top of this file giving credit > to Frederic? If for anything else, it will facilitate people to find who > broke it if it breaks ;-) > > I think Frederic should send one more patch to add his copyright. That is, > of course, if Frederic wants too. > > Note, Frederic did not ask me to post this. In fact, this is the first > time he's seen this complaint. I'm posting this because I was showing this > code to some students at a University and when I wanted to point out > who wrote it, I was surprised that Frederic's name was not mentioned. > I was looking at the code via LXR so git was not helpful here. Lai also did this work too, so I recommend adding something like: * Binary printk modifications, copyright 2009: * Frederic Weisbecker * Lai Jiangshan Or something similar. -- Steve