From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753186AbZERRDK (ORCPT ); Mon, 18 May 2009 13:03:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750890AbZERRDB (ORCPT ); Mon, 18 May 2009 13:03:01 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:48308 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793AbZERRDB (ORCPT ); Mon, 18 May 2009 13:03:01 -0400 Date: Mon, 18 May 2009 13:03:01 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: David Smith cc: Jon Masters , linux-kernel Subject: Re: [tracing] ring_buffer question In-Reply-To: <4A119264.9010807@redhat.com> Message-ID: References: <1242594505.6327.3.camel@localhost.localdomain> <1242607182.6327.8.camel@localhost.localdomain> <4A1185B9.8050301@redhat.com> <4A119264.9010807@redhat.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 May 2009, David Smith wrote: > Steven Rostedt wrote: > > On Mon, 18 May 2009, David Smith wrote: > > > >> Jon Masters wrote: > >>> [thinking out loud] Does the global disable stuff also disable other > >>> non-tracing ring buffers? > >> I believe it does. If I'm correct, I think it would be a good idea to > >> make that an ftrace-disable feature, not a general ring buffer disable > >> feature. > > > > We can do that when we get more users of the ring buffer and we find it > > makes sense. > > It appears that oprofile is already using the ring buffer. With Jon's > stuff as a 2nd non-ftrace-user, doesn't it make sense now? I guess it might also be something that we want to consider too. That is, the "tracing_off" is a nice feature for all users of the ring buffer. Once can stop and start the oprofiler buffer via the user interface "tracing_on" as well. Is this something that would also be useful? If we make it "ftrace only" then oprofile loses this feature. Now we could make a file for every registered user of the ring buffer. Well, not every registered user, but have the user register their own "tracing_on" file. -- Steve