From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756770AbZFIWq5 (ORCPT ); Tue, 9 Jun 2009 18:46:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750749AbZFIWqu (ORCPT ); Tue, 9 Jun 2009 18:46:50 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:65036 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752065AbZFIWqt (ORCPT ); Tue, 9 Jun 2009 18:46:49 -0400 Date: Tue, 9 Jun 2009 18:46:50 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Frederic Weisbecker cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Minchan Kim , Mel Gorman , Christoph Hellwig , Rik van Riel , Pekka Enberg , Peter Zijlstra , Theodore Tso , Mathieu Desnoyers , Lai Jiangshan , Zhaolei , KOSAKI Motohiro , Jason Baron , Jiaying Zhang , Tom Zanussi Subject: Re: [PATCH 4/8] tracing/events: modify irq print to new format In-Reply-To: <20090609222217.GE6057@nowhere> Message-ID: References: <20090609215211.307980196@goodmis.org> <20090609215339.384594898@goodmis.org> <20090609222217.GE6057@nowhere> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Jun 2009, Frederic Weisbecker wrote: > > > > /** > > @@ -106,8 +106,8 @@ TRACE_EVENT(softirq_entry, > > __entry->vec = (int)(h - vec); > > ), > > > > - TP_printk("softirq=%d action=%s", __entry->vec, > > - show_softirq_name(__entry->vec)) > > + TP_FORMAT("softirq= action= > > Just to zap the confusion, I would suggest to explicitly close the '>' here instead > of inside the macro. The current state suggests a kind of imbalance at a first glance. > > > > + show_softirq_name_args()) > > ); > > > > /** > > @@ -135,8 +135,8 @@ TRACE_EVENT(softirq_exit, > > __entry->vec = (int)(h - vec); > > ), > > > > - TP_printk("softirq=%d action=%s", __entry->vec, > > - show_softirq_name(__entry->vec)) > > + TP_FORMAT("softirq= action= > > And ditto. > Ah, yeah right. Now that I have the formats separated, I can do that. The first patch had it as one (format and args). I'll add a separate patch in my next set of patches that build on top of this one. -- Steve