From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758623AbZFKCA4 (ORCPT ); Wed, 10 Jun 2009 22:00:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754873AbZFKCAt (ORCPT ); Wed, 10 Jun 2009 22:00:49 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:34185 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752725AbZFKCAs (ORCPT ); Wed, 10 Jun 2009 22:00:48 -0400 Date: Wed, 10 Jun 2009 22:00:49 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Lai Jiangshan cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Thomas Gleixner , Peter Zijlstra , Frederic Weisbecker , Theodore Tso , Arnaldo Carvalho de Melo , Mathieu Desnoyers , "Martin J. Bligh" , Christoph Hellwig , Li Zefan , Huang Ying , "H. Peter Anvin" , Hidetoshi Seto , Masami Hiramatsu , Steven Rostedt Subject: Re: [PATCH 1/3] ring-buffer: make the buffer a true circular link list In-Reply-To: <4A305A1A.2010901@cn.fujitsu.com> Message-ID: References: <20090610195311.767699959@goodmis.org> <20090610195524.945549278@goodmis.org> <4A305A1A.2010901@cn.fujitsu.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Jun 2009, Lai Jiangshan wrote: > > - list_splice(&pages, head); > > + /* > > + * The ring buffer page list is a circular list that does not > > + * start and end with a list head. All page list items point to > > + * other pages. Remove one of the pages, init its list head, > > + * and use list splice to move the rest of the pages to it. > > + */ > > + bpage = list_entry(pages.next, struct buffer_page, list); > > + list_del_init(&bpage->list); > > + cpu_buffer->pages = &bpage->list; > > + > > + list_splice(&pages, cpu_buffer->pages); > > + > > Is it proper? > > cpu_buffer->pages = pages.next; > list_del(&pages); > Not sure what you are asking here? -- Steve > > > > rb_check_pages(cpu_buffer); > >