mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Justin Piszcz <jpiszcz@lucidpixels.com>
To: Felix Blyakher <felixb@sgi.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: Kernel 2.6.30: Memory/XFS leak, OOM killer kills many processes
Date: Fri, 12 Jun 2009 04:37:32 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.0906120420080.26259@p34.internal.lan> (raw)
In-Reply-To: <96F5FBF8-17B6-4AA9-BAB4-377AF596692C@sgi.com>



On Thu, 11 Jun 2009, Felix Blyakher wrote:

>
> On Jun 11, 2009, at 12:31 PM, Eric Sandeen wrote:
>
>> Justin Piszcz wrote:
>>> 
>>> On Thu, 11 Jun 2009, Justin Piszcz wrote:
>>> 
> The following should fix it:
>
> diff --git a/fs/xfs/xfs_bmap.c b/fs/xfs/xfs_bmap.c
> index 4b0f6ef..7928b99 100644
> --- a/fs/xfs/xfs_bmap.c
> +++ b/fs/xfs/xfs_bmap.c
> @@ -6086,6 +6086,7 @@ xfs_getbmap(
>                      break;
>      }
>
> +       kmem_free(out);
>      return error;
> }
>
>
> Felix

Just FYI if anyone tries to run the patch it will not work:

# patch -p1 < ../xfs.patch 
patching file fs/xfs/xfs_bmap.c
patch: **** malformed patch at line 11: }

So just goto line ~6086 and add the kmem_free(out); above the return 
error.

Status:
This patch fixes the problem, thanks!

Justin.


  reply	other threads:[~2009-06-12  8:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-11 16:15 Justin Piszcz
2009-06-11 17:00 ` Justin Piszcz
2009-06-11 17:31   ` Eric Sandeen
2009-06-11 19:02     ` Felix Blyakher
2009-06-11 22:02       ` Mike Dresser
2009-06-11 21:35     ` Felix Blyakher
2009-06-12  8:37       ` Justin Piszcz [this message]
2009-06-12  9:57         ` Michael Weissenbacher
2009-06-12 15:54         ` Felix Blyakher
2009-06-11 18:49 ` markus reichelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.0906120420080.26259@p34.internal.lan \
    --to=jpiszcz@lucidpixels.com \
    --cc=felixb@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®