mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Parag Warudkar <parag.lkml@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
	teawater@gmail.com, mingo@elte.hu, tj@kernel.org,
	xiyou.wangcong@gmail.com
Subject: [PATCH] elfcore.h : Fix UML build breakage
Date: Tue, 7 Jul 2009 22:41:50 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.0907072226140.24195@parag-desktop> (raw)

[-- Attachment #1: Type: TEXT/PLAIN, Size: 887 bytes --]

Commit a65e7bfcd74e4c0939f235d2bf9f48ddb3a57991 breaks UML build with 
below error - 

In file included from fs/proc/kcore.c:17:
include/linux/elfcore.h: In function ‘elf_core_copy_task_regs’:
include/linux/elfcore.h:129: error: implicit declaration of function 
‘task_pt_regs’

Fix this by restoring the previous behavior of returning 0 for all arches 
like UML that don't define task_pt_regs.

Signed-off-by: Parag Warudkar <parag.lkml@gmail.com>

diff --git a/include/linux/elfcore.h b/include/linux/elfcore.h
index 03ec167..28f722e 100644
--- a/include/linux/elfcore.h
+++ b/include/linux/elfcore.h
@@ -125,7 +125,7 @@ static inline int elf_core_copy_task_regs(struct task_struct *t, elf_gregset_t*
 #ifdef ELF_CORE_COPY_TASK_REGS
 	
 	return ELF_CORE_COPY_TASK_REGS(t, elfregs);
-#else
+#elif defined task_pt_regs
 	elf_core_copy_regs(elfregs, task_pt_regs(t));
 #endif
 	return 0;

             reply	other threads:[~2009-07-08  2:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-08  2:41 Parag Warudkar [this message]
2009-07-08  4:30 ` Amerigo Wang
2009-07-08 15:46   ` Parag Warudkar
2009-07-09  5:58     ` Amerigo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.0907072226140.24195@parag-desktop \
    --to=parag.lkml@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=teawater@gmail.com \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®