From: Dan Carpenter <error27@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: potential null dereference in sysfs_override_clocksource()
Date: Sun, 19 Jul 2009 16:04:48 +0300 (EAT) [thread overview]
Message-ID: <alpine.DEB.2.00.0907191545580.12306@bicker> (raw)
Hello,
I am testing a source checker (http://repo.or.cz/w/smatch.git).
It found an issue in sysfs_override_clocksource() from
kernel/time/clocksource.c. If "len" is zero then "ovr" is null and
checking ovr->flags will oops on line 517.
kernel/time/clocksource.c
516 if (tick_oneshot_mode_active() &&
517 !(ovr->flags & CLOCK_SOURCE_VALID_FOR_HRES)) {
518 printk(KERN_WARNING "%s clocksource is not HRT compatible. "
regards,
dan carpenter
next reply other threads:[~2009-07-19 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-19 13:04 Dan Carpenter [this message]
2009-07-19 15:12 ` Thomas Gleixner
2009-07-19 15:19 ` [tip:timers/urgent] clocksource: Prevent NULL pointer dereference tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.0907191545580.12306@bicker \
--to=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome