From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753731AbZGWOws (ORCPT ); Thu, 23 Jul 2009 10:52:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752701AbZGWOws (ORCPT ); Thu, 23 Jul 2009 10:52:48 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:32802 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168AbZGWOwr (ORCPT ); Thu, 23 Jul 2009 10:52:47 -0400 Date: Thu, 23 Jul 2009 10:52:47 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Matt Fleming cc: Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH -tip] ftrace: Correctly calculate the first function in the .text section In-Reply-To: Message-ID: References: <1248342703-15758-1-git-send-email-matt@console-pimps.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 Jul 2009, Steven Rostedt wrote: > > > > > if (!defined($ref_func) || !defined($weak{$text})) { > > to > > if (!defined($ref_func) && !defined($weak{$text})) { > > > > This now matches the comment above the conditional. > > This is the true bug. But the previous is not. Could you resend the patch with this fix only. Then I can send it out as an ugent fix. Thanks! -- Steve