mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Dave Airlie <airlied@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linuxppc-dev@ozlabs.org
Subject: Re: ftrace scripts and make V=1
Date: Thu, 6 Aug 2009 11:02:20 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.0908061100580.22376@gandalf.stny.rr.com> (raw)
In-Reply-To: <20090806034325.GA8861@elte.hu>


On Thu, 6 Aug 2009, Ingo Molnar wrote:
> > diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
> > index d29baa2..4889c44 100755
> > --- a/scripts/recordmcount.pl
> > +++ b/scripts/recordmcount.pl
> > @@ -414,7 +414,10 @@ while (<IN>) {
> >  	    $offset = hex $1;
> >  	} else {
> >  	    # if we already have a function, and this is weak, skip it
> > -	    if (!defined($ref_func) && !defined($weak{$text})) {
> > +	    if (!defined($ref_func) && !defined($weak{$text}) &&
> > +		 # PPC64 can have symbols that start with .L and
> > +		 # gcc considers these special. Don't use them!
> > +		 $text !~ /^\.L/) {
> >  		$ref_func = $text;
> >  		$offset = hex $1;
> >  	    }
> 
> Ah, indeed. I'm wondering whether also emitting a build warning 
> would be useful - just in the (admittedly unlikely) case of someone 
> wondering about why LM93_IN_FROM_REG does not show up in function 
> traces.

Actually, it just skips it as the function to use as the reference point. 
It should still record the mcount for that function. Now we may have an 
issues if all functions in a section start with .L

-- Steve


  reply	other threads:[~2009-08-06 15:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-05  7:23 Dave Airlie
2009-08-05  7:29 ` Ingo Molnar
2009-08-06  2:00   ` Steven Rostedt
2009-08-06  3:43     ` Ingo Molnar
2009-08-06 15:02       ` Steven Rostedt [this message]
2009-08-06 12:25     ` [tip:tracing/urgent] tracing: do not use functions starting with .L in recordmcount.pl tip-bot for Steven Rostedt
2009-08-06 12:34       ` Ingo Molnar
2009-08-05  8:08 ` ftrace scripts and make V=1 Sam Ravnborg
2009-08-05  8:18   ` Ingo Molnar
2009-08-05  8:52 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.0908061100580.22376@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=airlied@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®