From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Greg KH <gregkh@suse.de>, Roland Dreier <rdreier@cisco.com>,
Matt Fleming <matt@console-pimps.org>,
David Kiliani <mail@davidkiliani.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: [GIT PULL][2.6.31] tracing: have recordmcount.pl handle a section with only weak functions
Date: Thu, 6 Aug 2009 20:01:44 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.00.0908062000400.2840@gandalf.stny.rr.com> (raw)
In-Reply-To: <20090806233208.GA29339@suse.de>
Ingo,
Please pull the latest tip/tracing/urgent tree, which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
tip/tracing/urgent
Steven Rostedt (1):
tracing: have recordmcount.pl handle a section with only weak functions
----
scripts/recordmcount.pl | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
---------------------------
commit 0484219980fd985528f66bf620362859e617bb37
Author: Steven Rostedt <srostedt@redhat.com>
Date: Thu Aug 6 19:53:18 2009 -0400
tracing: have recordmcount.pl handle a section with only weak functions
Roland Dreier found that a section that contained only a weak function
in one of the staging drivers and this caused recordmcount.pl to spit
out a warning and fail. Although it is strange that a driver would have
a weak function, and this function only be used in one place, it should
not be something to make recordmcount.pl fail.
This patch fixes the issue in a simple manner. If only weak functions
exist in a section, than that section will not be recorded.
Reported-by: Roland Dreier <rdreier@cisco.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
index 4889c44..911ba7f 100755
--- a/scripts/recordmcount.pl
+++ b/scripts/recordmcount.pl
@@ -393,7 +393,7 @@ while (<IN>) {
$read_function = 0;
}
# print out any recorded offsets
- update_funcs() if ($text_found);
+ update_funcs() if (defined($ref_func));
# reset all markers and arrays
$text_found = 0;
@@ -444,7 +444,7 @@ while (<IN>) {
}
# dump out anymore offsets that may have been found
-update_funcs() if ($text_found);
+update_funcs() if (defined($ref_func));
# If we did not find any mcount callers, we are done (do nothing).
if (!$opened) {
next prev parent reply other threads:[~2009-08-07 0:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 21:37 drivers/staging/meilhaus build broken with ftrace Roland Dreier
2009-08-06 21:46 ` Steven Rostedt
2009-08-06 22:29 ` Greg KH
2009-08-06 22:47 ` Steven Rostedt
2009-08-06 22:51 ` Steven Rostedt
2009-08-06 22:58 ` Roland Dreier
2009-08-06 23:32 ` Greg KH
2009-08-07 0:01 ` Steven Rostedt [this message]
2009-08-07 6:50 ` [GIT PULL][2.6.31] tracing: have recordmcount.pl handle a section with only weak functions Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.0908062000400.2840@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@davidkiliani.de \
--cc=matt@console-pimps.org \
--cc=mingo@elte.hu \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®