From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756986AbZHGDbF (ORCPT ); Thu, 6 Aug 2009 23:31:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756548AbZHGDbF (ORCPT ); Thu, 6 Aug 2009 23:31:05 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:65389 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752166AbZHGDbD (ORCPT ); Thu, 6 Aug 2009 23:31:03 -0400 Date: Thu, 6 Aug 2009 23:31:03 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Li Zefan cc: Frederic Weisbecker , Ingo Molnar , LKML Subject: Re: [PATCH 3/3] tracing/filters: Support filtering for char * strings In-Reply-To: <4A7B9E6B.2090202@cn.fujitsu.com> Message-ID: References: <4A7A72BD.5030201@cn.fujitsu.com> <4A7A72FA.9040102@cn.fujitsu.com> <4A7B8149.3070901@cn.fujitsu.com> <4A7B9BB5.3040005@cn.fujitsu.com> <4A7B9E6B.2090202@cn.fujitsu.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 7 Aug 2009, Li Zefan wrote: > Steven Rostedt wrote: > > Ah, so the answer I'm looking for is: > > > > The filtering will not dereference "char *" unless the developer > > explicitly sets FILTER_PTR_STR in __field_ext. > > > > Is this above statement correct? > > > > Exactly. Sorry that I didn't explain it clearly in the > first place. :) No problem. It is quite often that things so blatantly obvious to a developer is totally foreign for the observer, that the simple explanation is commonly overlooked. I'll pull in your patches, with the -1 update, as well as adding my above statement to this patch's change log. I'll queue it for 32. Thanks! -- Steve