mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Justin Piszcz <jpiszcz@lucidpixels.com>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	john stultz <johnstul@us.ibm.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Arjan van de Ven <arjan@infradead.org>
Subject: RE: 2.6.31.4: WARNING: at arch/x86/kernel/hpet.c:390 hpet_next_event+0x70/0x80() [occurs when ACPI_PROCESSOR=y]
Date: Sat, 14 Nov 2009 03:48:48 -0500 (EST)	[thread overview]
Message-ID: <alpine.DEB.2.00.0911140344430.29547@p34.internal.lan> (raw)
In-Reply-To: <1258161139.21141.29.camel@localhost.localdomain>



On Fri, 13 Nov 2009, Pallipadi, Venkatesh wrote:

> On Fri, 2009-11-13 at 10:43 -0800, Justin Piszcz wrote:
>>
>> On Fri, 13 Nov 2009, Pallipadi, Venkatesh wrote:
>>
>>> On Fri, 2009-11-13 at 01:38 -0800, Thomas Gleixner wrote:
>>>> On Thu, 12 Nov 2009, Pallipadi, Venkatesh wrote:
>>>>> Yes. Yes. This is a hardware errata. I have a patch to workaround this and
>>>>> waiting on the errata description to get published..
>>>>
>>>> Can we at least have some PCI quirk or whatever until you can push the
>>>> final workaround out so peoples machines do not explode ?
>>>
>>> Its a harmless bug functionality-wise and should not have any side
>>> effect other than triggering the WARN_ON_ONCE in hpet next event code.
>>>
>>> Thanks,
>>> Venki
>>>
>>
>> Venki,
>>
>> When the following patch is applied though: (courtesy of john stultz)
>>
>
> Justin,
>
> I am missing something in here.
> Without the below patch, on 2.6.31.4 and ACPI_PROCESSOR loaded (either
> as module or builtin), you may see the WARNING. But, that should not
> cause any other problems with C-states, P-states, or anything else.
> Is that what you are seeing?
>
> The below patch is not a workaround for the problem. Infact it will make
> situation worse with constant stream of prinkts and can reduce the
> C-state residency and turbo upside.
>
> Thanks,
> Venki

Venki,

Without the below patch and ACPI_PROCESSOR loaded:

1. the warning? yes--however..
2. my processor does not enter turbo boost mode without the processor
    module
-
3. the patch shows that the hpet writes are failing-- when the processor
    module is loaded, the cpu/mobo/vrm emits a high-pitch noise-- my guess
    is due to the hpet write failures, failing over and over, this does
    not occur when the processor module is not loaded.

Justin.



  reply	other threads:[~2009-11-14  8:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-08 14:35 2.6.31.4: WARNING: at arch/x86/kernel/hpet.c:390 hpet_next_event+0x70/0x80() Justin Piszcz
2009-11-11 19:50 ` Dave Jones
2009-11-11 21:32   ` 2.6.31.4: WARNING: at arch/x86/kernel/hpet.c:390 hpet_next_event+0x70/0x80() [occurs when ACPI_PROCESSOR=y] Justin Piszcz
2009-11-12 16:26     ` Justin Piszcz
2009-11-12 16:33       ` Justin Piszcz
2009-11-12 23:39         ` Justin Piszcz
     [not found]         ` <1f1b08da0911121513l32d47b4x8b9722ad3440ceb6@mail.gmail.com>
     [not found]           ` <alpine.DEB.2.00.0911121824290.2852@p34.internal.lan>
2009-11-12 23:40             ` john stultz
2009-11-12 23:45               ` Justin Piszcz
2009-11-12 23:49                 ` john stultz
2009-11-12 23:53                   ` Justin Piszcz
2009-11-12 23:53               ` Thomas Gleixner
2009-11-12 23:56                 ` Justin Piszcz
2009-11-13  0:18                   ` Pallipadi, Venkatesh
2009-11-13  0:20                     ` Justin Piszcz
2009-11-13  0:30                       ` Pallipadi, Venkatesh
2009-11-13  9:38                     ` Thomas Gleixner
2009-11-13 18:32                       ` Pallipadi, Venkatesh
2009-11-13 18:43                         ` Justin Piszcz
2009-11-14  1:12                           ` Pallipadi, Venkatesh
2009-11-14  8:48                             ` Justin Piszcz [this message]
2009-11-17 11:45                               ` Justin Piszcz
2009-11-17 21:37                                 ` Pallipadi, Venkatesh
2009-11-17 22:53                                   ` Justin Piszcz
2009-11-19 22:08                                     ` Pallipadi, Venkatesh
2009-11-19 23:12                                       ` Justin Piszcz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.0911140344430.29547@p34.internal.lan \
    --to=jpiszcz@lucidpixels.com \
    --cc=arjan@infradead.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®