From: Christoph Lameter <cl@linux-foundation.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Adam Litke <agl@us.ibm.com>, Avi Kivity <avi@redhat.com>,
David Rientjes <rientjes@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
"hugh.dickins@tiscali.co.uk" <hugh.dickins@tiscali.co.uk>
Subject: Re: [PATCH 03/12] mm: Share the anon_vma ref counts between KSM and page migration
Date: Fri, 19 Feb 2010 09:01:44 -0600 (CST) [thread overview]
Message-ID: <alpine.DEB.2.00.1002190857230.7486@router.home> (raw)
In-Reply-To: <20100219140500.GG30258@csn.ul.ie>
On Fri, 19 Feb 2010, Mel Gorman wrote:
> > Nitpick:
> > I think this refcnt has something different characteristics than other
> > usual refcnts. Even when refcnt goes down to 0, anon_vma will not be freed.
> > So, I think some kind of name as temporal_reference_count is better than
> > simple "refcnt". Then, it will be clearer what this refcnt is for.
> >
>
> When I read this in a few years, I'll have no idea what "temporal" is
> referring to. The holder of this account is by a process that does not
> necessarily own the page or its mappings but "remote" has special
> meaning as well. "external_count" ?
We could think about getting rid of RCU for anon_vmas and use the refcount
for everything. Would make the handling consistent with other users but
will have performance implications.
Hugh what do you say about this?
next prev parent reply other threads:[~2010-02-19 15:02 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 18:02 [PATCH 0/12] Memory Compaction v3 Mel Gorman
2010-02-18 18:02 ` [PATCH 01/12] mm,migration: Take a reference to the anon_vma before migrating Mel Gorman
2010-02-19 0:12 ` KAMEZAWA Hiroyuki
2010-02-19 13:59 ` Mel Gorman
2010-02-19 16:43 ` Rik van Riel
2010-02-18 18:02 ` [PATCH 02/12] mm,migration: Do not try to migrate unmapped anonymous pages Mel Gorman
2010-02-19 16:45 ` Rik van Riel
2010-02-18 18:02 ` [PATCH 03/12] mm: Share the anon_vma ref counts between KSM and page migration Mel Gorman
2010-02-19 0:18 ` KAMEZAWA Hiroyuki
2010-02-19 14:05 ` Mel Gorman
2010-02-19 15:01 ` Christoph Lameter [this message]
2010-02-20 3:48 ` KAMEZAWA Hiroyuki
2010-02-20 9:32 ` Mel Gorman
2010-02-19 5:09 ` Minchan Kim
2010-02-19 21:42 ` Rik van Riel
2010-02-19 21:58 ` Mel Gorman
2010-02-20 0:16 ` Rik van Riel
2010-02-20 9:29 ` Mel Gorman
2010-02-18 18:02 ` [PATCH 04/12] mm: Document /proc/pagetypeinfo Mel Gorman
2010-02-19 1:36 ` Minchan Kim
2010-02-19 21:42 ` Rik van Riel
2010-02-18 18:02 ` [PATCH 05/12] Allow CONFIG_MIGRATION to be set without CONFIG_NUMA or memory hot-remove Mel Gorman
2010-02-19 0:21 ` KAMEZAWA Hiroyuki
2010-02-19 14:09 ` Mel Gorman
2010-02-18 18:02 ` [PATCH 06/12] Export unusable free space index via /proc/pagetypeinfo Mel Gorman
2010-02-19 1:35 ` Minchan Kim
2010-02-19 21:46 ` Rik van Riel
2010-02-18 18:02 ` [PATCH 07/12] Export fragmentation " Mel Gorman
2010-02-19 1:59 ` Minchan Kim
2010-02-20 0:16 ` Rik van Riel
2010-02-18 18:02 ` [PATCH 08/12] Memory compaction core Mel Gorman
2010-02-19 0:37 ` KAMEZAWA Hiroyuki
2010-02-19 14:15 ` Mel Gorman
2010-02-18 18:02 ` [PATCH 09/12] Add /proc trigger for memory compaction Mel Gorman
2010-02-19 0:43 ` KAMEZAWA Hiroyuki
2010-02-19 14:16 ` Mel Gorman
2010-02-20 3:53 ` KAMEZAWA Hiroyuki
2010-02-19 2:26 ` Minchan Kim
2010-02-18 18:02 ` [PATCH 10/12] Add /sys trigger for per-node " Mel Gorman
2010-02-19 14:53 ` Greg KH
2010-02-19 15:28 ` Mel Gorman
2010-02-19 15:31 ` Greg KH
2010-02-19 15:51 ` Mel Gorman
2010-02-19 15:52 ` Mel Gorman
2010-02-19 16:02 ` Greg KH
2010-02-18 18:02 ` [PATCH 11/12] Direct compact when a high-order allocation fails Mel Gorman
2010-02-19 0:51 ` KAMEZAWA Hiroyuki
2010-02-19 14:19 ` Mel Gorman
2010-02-19 2:41 ` Minchan Kim
2010-02-19 14:25 ` Mel Gorman
2010-02-18 18:02 ` [PATCH 12/12] Do not compact within a preferred zone after a compaction failure Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1002190857230.7486@router.home \
--to=cl@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=agl@us.ibm.com \
--cc=avi@redhat.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®