From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Bastian Blank <waldi@debian.org>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH 4 of 4] Linux pvops: xen pci platform device driver
Date: Wed, 3 Mar 2010 18:26:12 +0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1003031808310.4648@kaball-desktop> (raw)
In-Reply-To: <20100303161428.GB26656@wavehammer.waldi.eu.org>
On Wed, 3 Mar 2010, Bastian Blank wrote:
> > During the initialization of the xen pci device driver, we write to a
> > magic ioport that causes qemu to unplug some emulated devices, disc and
> > network in particular.
> > This parameter is meant to present the user a choice about what emulated
> > devices to unplug.
>
> Somehow I don't think this belongs here. It looks like a workaround, you
> can always ask qemu to not bind them at the beginning and the guest
> system to not provide drivers.
>
Most of the time you just want to unplug all or nothing, so removing the
option is generally not a problem.
However it can still be useful for debugging: let's say that blkfront
doesn't work properly, if the xen pci platform driver unplugs the IDE
disk at init time the guest won't be able to boot.
This fact just made me realize that the xen pci platform driver should
depend on netfront and blkfront too if we make "unplug all" the default.
> > > > +#define XEN_IOPORT_BASE 0x10
> > >
> > > Why are this constants defined in the driver themself? They only make
> > > sense if there are two components making use of them.
> > Yep, the other one is qemu.
>
> Well, if it is a published interface move it into a header file.
>
Good idea
next prev parent reply other threads:[~2010-03-03 18:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 18:31 Stefano Stabellini
2010-03-03 12:17 ` [Xen-devel] " Bastian Blank
2010-03-03 15:52 ` Stefano Stabellini
2010-03-03 16:14 ` Bastian Blank
2010-03-03 18:26 ` Stefano Stabellini [this message]
2010-03-04 15:26 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1003031808310.4648@kaball-desktop \
--to=stefano.stabellini@eu.citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=waldi@debian.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®