From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756035Ab0CIU4F (ORCPT <rfc822;w@1wt.eu>);
	Tue, 9 Mar 2010 15:56:05 -0500
Received: from nlpi157.sbcis.sbc.com ([207.115.36.171]:56927 "EHLO
	nlpi157.prodigy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755555Ab0CIU4C (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 9 Mar 2010 15:56:02 -0500
Date: Tue, 9 Mar 2010 14:55:39 -0600 (CST)
From: Christoph Lameter <cl@linux-foundation.org>
X-X-Sender: cl@router.home
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
cc: Andrew Morton <akpm@linux-foundation.org>,
       Thomas Gleixner <tglx@linutronix.de>,
       LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org,
       Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: mm: Do not iterate over NR_CPUS in __zone_pcp_update()
In-Reply-To: <alpine.LFD.2.00.1003091530230.11928@localhost>
Message-ID: <alpine.DEB.2.00.1003091454210.28897@router.home>
References: <alpine.LFD.2.00.1003081018070.22855@localhost.localdomain> <20100309122253.3f3d4a53.akpm@linux-foundation.org> <alpine.LFD.2.00.1003091530230.11928@localhost>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 9 Mar 2010, Robert P. J. Day wrote:

> > I'm having trouble working out whether we want to backport this into
> > 2.6.33.x or earlier.  Help?
>
>   given the above aesthetic mod, shouldn't that same change be applied
> to *all* explicit loops of that form?  after all, checkpatch.pl warns
> against it:

The number of NR_CPUS should be significantly less after the percpu
rework. Would you audit the kernel for NR_CPUS use?