From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755089Ab0EMRW4 (ORCPT ); Thu, 13 May 2010 13:22:56 -0400 Received: from nlpi157.sbcis.sbc.com ([207.115.36.171]:34889 "EHLO nlpi157.prodigy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752270Ab0EMRWz (ORCPT ); Thu, 13 May 2010 13:22:55 -0400 Date: Thu, 13 May 2010 12:22:01 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@router.home To: KAMEZAWA Hiroyuki cc: Andrew Morton , KOSAKI Motohiro , Mel Gorman , Linus Torvalds , Linux-MM , LKML , Minchan Kim , Andrea Arcangeli , Rik van Riel , Peter Zijlstra Subject: Re: [PATCH] mm,migration: Avoid race between shift_arg_pages() and rmap_walk() during migration by not migrating temporary stacks In-Reply-To: <20100513091930.9b42e3b8.kamezawa.hiroyu@jp.fujitsu.com> Message-ID: References: <20100511085752.GM26611@csn.ul.ie> <20100512092239.2120.A69D9226@jp.fujitsu.com> <20100512125427.d1b170ba.akpm@linux-foundation.org> <20100513091930.9b42e3b8.kamezawa.hiroyu@jp.fujitsu.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 May 2010, KAMEZAWA Hiroyuki wrote: > > Would it not be possible to do something similar for the temporary stack? > > > > Problem here is unmap->remap. ->migratepage() function is used as > > unmap > -> migratepage() > -> failed > -> remap > > Then, migratepage() itself is no help. We need some check-callback before unmap > or lock to wait for an event we can make remapping progress. We could check earlier if the migrate function points to fail_migrate_page()? Where we check for PageKsm() in unmap_and_move f.e.?