Re: [PATCH] remove mmu notifier calls in apply_to_page_range

[Stefano Stabellini <stefano.stabellini@eu.citrix.com>]

On Fri, 9 Jul 2010, Jeremy Fitzhardinge wrote:
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 6ab19dd..d6b89eb 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -1890,7 +1890,6 @@ int apply_to_page_range(struct mm_struct *mm, unsigned long addr,
>  	int err;
>  
>  	BUG_ON(addr >= end);
> -	mmu_notifier_invalidate_range_start(mm, start, end);
>  	pgd = pgd_offset(mm, addr);
>  	do {
>  		next = pgd_addr_end(addr, end);
> @@ -1898,7 +1897,7 @@ int apply_to_page_range(struct mm_struct *mm, unsigned long addr,
>  		if (err)
>  			break;
>  	} while (pgd++, addr = next, addr != end);
> -	mmu_notifier_invalidate_range_end(mm, start, end);
> +
>  	return err;
>  }
>  EXPORT_SYMBOL_GPL(apply_to_page_range);
> 
> 
> 

The local variable start in apply_to_page_range is not used anymore:
remove it.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

---

diff --git a/mm/memory.c b/mm/memory.c
index 9d33bfe..0a47927 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1989,7 +1989,7 @@ int apply_to_page_range(struct mm_struct *mm, unsigned long addr,
 {
 	pgd_t *pgd;
 	unsigned long next;
-	unsigned long start = addr, end = addr + size;
+	unsigned long end = addr + size;
 	int err;
 
 	BUG_ON(addr >= end);