mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov,
	dave@linux.vnet.ibm.com,
	Andrew Morton <akpm@linux-foundation.org>,
	jmorris@namei.org, sds@tycho.nsa.gov
Subject: Re: [PATCH] flex_array: add helpers to get and put to make pointers easy to use
Date: Tue, 3 Aug 2010 15:43:41 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1008031540510.25322@chino.kir.corp.google.com> (raw)
In-Reply-To: <1280873146.23348.7.camel@dhcp231-200.rdu.redhat.com>

On Tue, 3 Aug 2010, Eric Paris wrote:

> > > Getting and putting arrays of pointers with flex arrays is a PITA.  You
> > > have to remember to pass &ptr to the _put and you have to do weird and
> > > wacky casting to get the ptr back from the _get.  Add two functions
> > > flex_array_get_ptr() and flex_array_put_ptr() to handle all of the magic.
> > > 
> > 
> > There's no code currently in the tree that uses the flex array interface, 
> > so is this something that you've encountered in practice or only by 
> > inspection?  If it's the former, is that code on its way for 2.6.36?
> 
> I did decide to use flex_arrays on code intended for .36
> http://git.kernel.org/?p=linux/kernel/git/jmorris/security-testing-2.6.git;a=commitdiff;h=6371dcd36f649d9d07823f31400618155a20dde1
> 

Great, a user!  I'm hoping that more people will adopt this interface but 
I can't think of anything that could currently be converted.  Maybe we can 
find opportunities in patches as they're proposed to the list.

Thanks.

      reply	other threads:[~2010-08-03 22:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-03 19:36 Eric Paris
2010-08-03 19:53 ` Joe Perches
2010-08-03 20:55 ` David Rientjes
2010-08-03 22:05   ` Eric Paris
2010-08-03 22:43     ` David Rientjes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1008031540510.25322@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave@linux.vnet.ibm.com \
    --cc=eparis@redhat.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®