From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755584Ab0JBOFD (ORCPT ); Sat, 2 Oct 2010 10:05:03 -0400 Received: from x35.xmailserver.org ([64.71.152.41]:55349 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755300Ab0JBOFC (ORCPT ); Sat, 2 Oct 2010 10:05:02 -0400 X-AuthUser: davidel@xmailserver.org Date: Sat, 2 Oct 2010 07:04:51 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@davide-laptop To: "Eric W. Biederman" cc: Robin Holt , Pekka Enberg , Linux Kernel Mailing List Subject: Re: max_user_watches overflows on 16TB system. In-Reply-To: Message-ID: References: <20101001200143.GR14064@sgi.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Oct 2010, Eric W. Biederman wrote: > Davide Libenzi writes: > > > On Fri, 1 Oct 2010, Robin Holt wrote: > > > >> > >> Following a boot of a 16TB system, we noticed that the max_user_watches > >> sysctl was negative. Is there any downside to converting that to a > >> static long and handling the fallout from the change? I believe that > >> fallout includes changing the definition of epoll_watches over to an > >> atomic_long_t as well. > >> > >> Alternatively should we just limit max_user_watches to INT_MAX? > > > > 2B watches looks an acceptable limit to me, at least for now. > > Nobody complained about not having enough of them so far. > > Which suggests that we need to force the boot time calculation to not > exceed 2B. > > From the sysctl interface perspective now that all of it is exported as > ascii strings I don't see a problem there. Thinking with actual code at hands, you're right. It just makes more sense the 'long' variable conversion, even though MAX_INT watches are a huge number today. Robin, sorry for the confusion. Can you post the 'long' conversion patch? - Davide