From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2 01/10] xen: remap GSIs as pirqs when running as initial domain
Date: Wed, 6 Oct 2010 18:53:39 +0100 [thread overview]
Message-ID: <alpine.DEB.2.00.1010061802290.2440@kaball-desktop> (raw)
In-Reply-To: <20101006165022.GC1590@dumpdata.com>
On Wed, 6 Oct 2010, Konrad Rzeszutek Wilk wrote:
> > > > +void __init xen_setup_pirqs(void)
> > > > +{
> > > > + int irq;
> > > > +#ifndef CONFIG_SMP
> > > > + int nr_ioapics = 1;
> > > > +#endif
> > >
> > > Should this be defined in a header instead? Was this nr_ioapics==1
> > > meant to fall in the '0 == nr_ioapics' to setup the first sixteen
> > > irqs?
> > >
> > > Is CONFIG_X86_IO_APIC more appropiate than CONFIG_SMP?
> >
> > I think it was supposed to fix a compilation error in case
> > CONFIG_X86_IO_APIC is not set, so that in both cases in which an ioapic
> > is not present in the system or the ioapic support is not compiled in
> > the kernel we would fall in the '0 == nr_ioapics' code path.
>
> That is what I thought, but nr_ioapics is set to one, so how do
> we fall in 0 == 1 code path?
>
that was another mistake, I have fixed it now
next prev parent reply other threads:[~2010-10-06 17:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 11:27 [PATCH v2 00/10] xen: initial domain support Stefano Stabellini
2010-10-04 11:28 ` [PATCH v2 01/10] xen: remap GSIs as pirqs when running as initial domain stefano.stabellini
2010-10-04 19:24 ` [Xen-devel] " Konrad Rzeszutek Wilk
2010-10-05 13:11 ` Stefano Stabellini
2010-10-06 16:50 ` Konrad Rzeszutek Wilk
2010-10-06 17:53 ` Stefano Stabellini [this message]
2010-10-04 11:28 ` [PATCH v2 02/10] xen: remap MSIs into " stefano.stabellini
2010-10-04 11:28 ` [PATCH v2 03/10] xen: map a dummy page for local apic and ioapic in xen_set_fixmap stefano.stabellini
2010-10-04 11:28 ` [PATCH v2 04/10] xen: use vcpu_ops to setup cpu masks stefano.stabellini
2010-10-04 11:28 ` [PATCH v2 05/10] xen: Initialize xenbus for dom0 stefano.stabellini
2010-10-04 11:28 ` [PATCH v2 06/10] xen: add the direct mapping area for ISA bus access stefano.stabellini
2010-10-04 11:28 ` [PATCH v2 07/10] xen: introduce XEN_DOM0 as a silent option stefano.stabellini
2010-10-04 11:28 ` [PATCH v2 08/10] xen: use host E820 map for dom0 stefano.stabellini
2010-10-04 11:28 ` [PATCH v2 09/10] xen: make hvc_xen console work " stefano.stabellini
2010-10-04 11:28 ` [PATCH v2 10/10] xen: mask the MTRR feature from the cpuid stefano.stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1010061802290.2440@kaball-desktop \
--to=stefano.stabellini@eu.citrix.com \
--cc=Jeremy.Fitzhardinge@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®