From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755198Ab0K3UaJ (ORCPT ); Tue, 30 Nov 2010 15:30:09 -0500 Received: from georges.telenet-ops.be ([195.130.137.68]:53788 "EHLO georges.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753532Ab0K3UaI convert rfc822-to-8bit (ORCPT ); Tue, 30 Nov 2010 15:30:08 -0500 Date: Tue, 30 Nov 2010 21:30:01 +0100 (CET) From: Geert Uytterhoeven To: Miao Xie , Chris Mason cc: linux-btrfs@vger.kernel.org, Linux Kernel Development , Andrew Morton Subject: [PATCH] btrfs: Correct printing of sector_t Message-ID: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-7 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If CONFIG_LBDAF=y, `sector_t' becomes `u64' instead of `unsigned long': fs/btrfs/inode.c: In function ¡btrfs_end_dio_bio¢: fs/btrfs/inode.c:5717: warning: format ¡%lu¢ expects type ¡long unsigned int¢, but argument 4 has type ¡sector_t¢ Hence always cast it to `unsigned long long' for printing. Introduced by commit e65e1535542931e51189832264cd282e5899e4b9 ("btrfs: fix panic caused by direct IO") Signed-off-by: Geert Uytterhoeven --- fs/btrfs/inode.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 8039390..fbffe5f 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -5712,9 +5712,9 @@ static void btrfs_end_dio_bio(struct bio *bio, int err) if (err) { printk(KERN_ERR "btrfs direct IO failed ino %lu rw %lu " - "disk_bytenr %lu len %u err no %d\n", - dip->inode->i_ino, bio->bi_rw, bio->bi_sector, - bio->bi_size, err); + "disk_bytenr %llu len %u err no %d\n", + dip->inode->i_ino, bio->bi_rw, + (unsigned long long)bio->bi_sector, bio->bi_size, err); dip->errors = 1; /* -- 1.7.0.4 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds