From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752891Ab1AFS1Z (ORCPT ); Thu, 6 Jan 2011 13:27:25 -0500 Received: from utopia.booyaka.com ([72.9.107.138]:51075 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752845Ab1AFS1X (ORCPT ); Thu, 6 Jan 2011 13:27:23 -0500 Date: Thu, 6 Jan 2011 11:27:22 -0700 (MST) From: Paul Walmsley To: Kevin Hilman cc: Koen Kooi , Brad Parker , Anand Gadiyar , Ming Lei , Benoit Cousson , Stephen Rothwell , Greg KH , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Felipe Balbi , Tony Lindgren , linux-omap@vger.kernel.org Subject: Re: linux-next: manual merge of the usb tree with the omap tree In-Reply-To: <87pqs9vqya.fsf@ti.com> Message-ID: References: <20101223171859.f6842045.sfr@canb.auug.org.au> <4D139517.3010608@ti.com> <4ce0f816f951f24ca3de9c84d9f70842@mail.gmail.com> <4D25E313.4060202@heeltoe.com> <8B3471BB-CB3F-4CE6-B523-D9C5E87B9CEC@dominion.thruhere.net> <87pqs9vqya.fsf@ti.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Jan 2011, Kevin Hilman wrote: > Koen Kooi writes: > > > Op 6 jan 2011, om 16:43 heeft Brad Parker het volgende geschreven: > > > >> It's probably expected, but I can't get the EHCI USB port to work > >> on a beagle board XM (36xx) using the current omap tree. > >> > >> It this most likely due to these clock issues? > > > > You need this patch: http://thread.gmane.org/gmane.linux.ports.arm.omap/47807/ > > > > I'm currently too lazy to split it up like Nishant wants as I don't > > see the point splitting for the sake of splitting.-- > > IMO, it doesn't need to be split up. > > But it does have to fix the other comments I made on the same thread[1] > > 1) add a descriptive changelog, and > 2) Cc linux-arm-kernel and glancing at the patch 3) Fix the multiline comments to conform to Documentation/CodingStyle as I think Nishanth mentioned. - Paul