From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>
Subject: Re: [PATCH 09/11] xen: introduce gnttab_map_refs and gnttab_unmap_refs
Date: Mon, 10 Jan 2011 10:32:19 +0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1101071357420.2390@kaball-desktop> (raw)
In-Reply-To: <20110105202355.GB29993@dumpdata.com>
On Wed, 5 Jan 2011, Konrad Rzeszutek Wilk wrote:
> > +
> > + ret = HYPERVISOR_grant_table_op(GNTTABOP_map_grant_ref, map_ops, count);
> > +
> > + for (i = 0; i < count; i++) {
> > + pfn = mfn_to_pfn(map_ops[i].host_addr >> PAGE_SHIFT);
>
> Shouldn't you be checking the flag to see if this a bus address? You could
> also use the PFN_DOWN macro here..
Yes, actually I should be checking for GNTMAP_contains_pte.
> > + pte = (pte_t *) __va((pfn << PAGE_SHIFT) +
> > + (map_ops[i].host_addr & ~PAGE_MASK));
>
> PFN_PHYS(pfn)? Or better You could use the mfn_to_virt macro here:
>
> pte = (pte_t *) mfn_to_virt(PFN_DOWN(map_ops[i].ost_addr));
> pte += (map_ops[i].host_addr & _PAGE_MASK);
>
Good suggestion, I have applied it (plus a small change to the pointer
arithmetic).
> > + val = *pte;
> > + mfn = (native_pte_val(val) & PTE_PFN_MASK) >> PAGE_SHIFT;
>
> mfn = pte_mfn(pte) ?
>
yep, done that.
next prev parent reply other threads:[~2011-01-10 10:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 13:39 [PATCH 00/11] xen: allow usermode to map granted pages Stefano Stabellini
2010-12-15 13:40 ` [PATCH 01/11] xen: define gnttab_set_map_op/unmap_op stefano.stabellini
2011-01-05 20:25 ` Konrad Rzeszutek Wilk
2011-01-06 9:16 ` Ian Campbell
2010-12-15 13:40 ` [PATCH 02/11] xen/gntdev: allow usermode to map granted pages stefano.stabellini
2011-01-05 20:25 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-01-10 10:33 ` Stefano Stabellini
2010-12-15 13:40 ` [PATCH 03/11] xen/gntdev: add VM_PFNMAP to vma stefano.stabellini
2010-12-15 13:40 ` [PATCH 04/11] xen: move p2m handling to separate file stefano.stabellini
2011-01-05 20:24 ` Konrad Rzeszutek Wilk
2010-12-15 13:40 ` [PATCH 05/11] xen: add m2p override mechanism stefano.stabellini
2010-12-15 13:40 ` [PATCH 06/11] xen: gntdev: move use of GNTMAP_contains_pte next to the map_op stefano.stabellini
2011-01-05 20:24 ` Konrad Rzeszutek Wilk
2011-01-10 10:32 ` Stefano Stabellini
2011-01-10 21:16 ` Konrad Rzeszutek Wilk
2010-12-15 13:40 ` [PATCH 07/11] xen/gntdev: stop using "token" argument stefano.stabellini
2010-12-15 13:40 ` [PATCH 08/11] xen p2m: transparently change the p2m mappings in the m2p override stefano.stabellini
2010-12-15 23:36 ` [Xen-devel] " Jeremy Fitzhardinge
2010-12-16 15:25 ` Stefano Stabellini
2011-01-05 20:24 ` Konrad Rzeszutek Wilk
2010-12-15 13:40 ` [PATCH 09/11] xen: introduce gnttab_map_refs and gnttab_unmap_refs stefano.stabellini
2011-01-05 20:23 ` Konrad Rzeszutek Wilk
2011-01-10 10:32 ` Stefano Stabellini [this message]
2010-12-15 13:40 ` [PATCH 10/11] xen gntdev: use " stefano.stabellini
2011-01-05 20:23 ` Konrad Rzeszutek Wilk
2011-01-10 10:33 ` Stefano Stabellini
2010-12-15 13:40 ` [PATCH 11/11] xen p2m: clear the old pte when adding a page to m2p_override stefano.stabellini
2011-01-05 20:23 ` Konrad Rzeszutek Wilk
2011-01-10 10:32 ` Stefano Stabellini
2010-12-15 13:43 ` [PATCH 00/11] xen: allow usermode to map granted pages Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1101071357420.2390@kaball-desktop \
--to=stefano.stabellini@eu.citrix.com \
--cc=Jeremy.Fitzhardinge@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®