From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755451Ab1BHDJh (ORCPT ); Mon, 7 Feb 2011 22:09:37 -0500 Received: from utopia.booyaka.com ([72.9.107.138]:41224 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755097Ab1BHDJg (ORCPT ); Mon, 7 Feb 2011 22:09:36 -0500 Date: Mon, 7 Feb 2011 20:09:34 -0700 (MST) From: Paul Walmsley To: John Ogness cc: Tony Lindgren , Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, balbi@ti.com Subject: Re: [PATCH v3] OMAP2/3: clock: fix fint calculation for DPLL_FREQSEL In-Reply-To: <87y66e3bc2.fsf_-_@vostro.fn.ogness.net> Message-ID: References: <87ei8726wf.fsf@vostro.fn.ogness.net> <20110120111645.GB2223@legolas.emea.dhcp.ti.com> <8739on1wdd.fsf_-_@vostro.fn.ogness.net> <20110121031553.GA2448@legolas.emea.dhcp.ti.com> <87y66e3bc2.fsf_-_@vostro.fn.ogness.net> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Jan 2011, John Ogness wrote: > From: John Ogness > > In OMAP35X TRM Rev 2010-05 Figure 7-18 "DPLL With EMI Reduction > Feature", it is shown that the internal frequency is calculated by > CLK_IN/(N+1). However, the value passed to _dpll_test_fint() is > already "N+1" since Linux is using the values to divide by. In the > technical reference manual, "N" is referring to the divider's register > value (0-127). > > Signed-off-by: John Ogness Thanks for the patch, John. Probably this should go into the -rc series since it could affect system stability, so will queue it there. - Paul