Re: [PATCH urgent] x86: Save cr4 to mmu_cr4_features at boot time

[Stefano Stabellini <stefano.stabellini@eu.citrix.com>]

On Fri, 1 Apr 2011, Ingo Molnar wrote:
> * Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
> > I asked for a backport of e5f15b45ddf3afa2bbbb10c7ea34fb32b6de0a0e to the 
> > stable trees because I forgot to add "CC stable@kernel.org" to the commit 
> > message and this commit is needed to fix a critical crash on boot on xen.
> 
> You are displaying a dangerously amateurish attitude towards quality control 
> and you clealy have no idea what it takes to push fixes into -stable.
> 
> You forwarded a brand-new, visibly dangerous native kernel commit to -stable 
> without Cc:-ing the maintainers and you have caused a native kernel regression 
> that way. You are not maintaining the code in question and you have not 
> committed the patch in question.


Just to clarify the situation the patch "x86-64: finish
cleanup_highmaps()'s job wrt. _brk_end" was backported to the stable
trees (including Jeremy's 2.6.32 xen tree because he pulled from
2.6.32.y) breaking boot on xen.
Yinghai's patch plus another patch of mine fix that breakage and that is
why I ask for it to be backported.
I didn't mean for the backport to be done right now, I just wanted to
notify the stable maintainers that the particular commit should be
backported at some point.

I didn't mean to overstep your authority in any way.
I know that ignorance is never an excuse but I am still new to this and
my knowledge of how the process works is limited to a blog entry by Greg
KH from an year ago.
I realize that stable trees are really important so I am very sorry to
have introduced such an important breakage.