mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	Ian Campbell <Ian.Campbell@eu.citrix.com>,
	"JBeulich@novell.com" <JBeulich@novell.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: RE: [PATCH v2 2/2] x86: don't unmask disabled irqs when migrating them
Date: Thu, 19 May 2011 13:08:07 +0100	[thread overview]
Message-ID: <alpine.DEB.2.00.1105191304530.12963@kaball-desktop> (raw)
In-Reply-To: <625BA99ED14B2D499DC4E29D8138F1505C9BBF8D40@shsmsx502.ccr.corp.intel.com>

On Thu, 19 May 2011, Tian, Kevin wrote:
> for [1/2] I think it's still necessary as it's meaningless to migrate a percpu type irq.
> However Stefano has sent out a cleanup patch for Xen percpu irqchip which uses
> nop mask/unmask hack borrowed from uv machine to work around the issue. As
> you suggested it's better to consolidate into the common place instead of scattering
> in different places. My view on this common logic is what [1/2] tries to address, is
> it correct? If yes, would you consider taking this patch? Stefano told me that his
> patches will go in in next merge window. So I think either you can take [1/2] now and
> then I'll do cleanup after Stefano's patch is in, or I can rebase my [1/2] after Stefano's
> patch to clean both xen and uv parts. 

Actually I think Kevin's generic patch is better too.
If you ack it I'll remove my patch right away from the queue (maybe I
should remove it anyway?).
Kevin probably needs to write a cleanup patch to remove the equivalent
hack from the uv_irq.

  reply	other threads:[~2011-05-19 12:06 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-06  6:43 Tian, Kevin
2011-05-06  9:59 ` Thomas Gleixner
2011-05-06 12:54   ` Tian, Kevin
2011-05-06 13:14     ` [Xen-devel] " Tian, Kevin
2011-05-06 13:24     ` Thomas Gleixner
2011-05-06 14:04       ` Ian Campbell
2011-05-08  1:44         ` Jeremy Fitzhardinge
2011-05-09  0:44           ` Tian, Kevin
2011-05-09  1:45             ` Jeremy Fitzhardinge
2011-05-06 14:28     ` Stefano Stabellini
2011-05-06 21:43       ` Tian, Kevin
2011-05-09  2:11       ` Tian, Kevin
2011-05-09 12:02         ` Stefano Stabellini
2011-05-09 12:36           ` Thomas Gleixner
2011-05-10  3:24             ` Tian, Kevin
2011-05-18 23:49               ` Tian, Kevin
2011-05-19 12:08                 ` Stefano Stabellini [this message]
2011-05-19 16:18                   ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-08-29  4:15 ` [regression] Ideapad S10-3 does not wake up from suspend (Re: [PATCH v2 2/2] x86: don't unmask disabled irqs when migrating them) Jonathan Nieder
2011-08-31  1:04   ` Dave Hansen
2011-08-31  8:22     ` Jonathan Nieder
2011-09-02  3:01       ` Serge E. Hallyn
2011-09-01  6:24   ` Tian, Kevin
2012-05-12 23:13     ` [regression] Ideapad S10-3 does not wake up from suspend Jonathan Nieder
2012-05-13  1:22       ` Lars Boegild Thomsen
2012-07-15 23:24         ` Jonathan Nieder
2012-04-15 14:06   ` Jonathan Nieder
2012-04-16 18:05     ` Robert Scott
2012-04-17  2:04       ` Jonathan Nieder
2012-04-18 10:03         ` Lars Boegild Thomsen
2012-04-22 16:34           ` [Xen-devel] " Pasi Kärkkäinen
2012-04-21 13:14         ` Robert Scott
2012-05-06 12:44         ` Robert Scott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1105191304530.12963@kaball-desktop \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=JBeulich@novell.com \
    --cc=hpa@zytor.com \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®