From: Pekka Enberg <penberg@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next-20110718] Fix build error at mm/slab.c .
Date: Wed, 20 Jul 2011 20:37:00 +0300 (EEST) [thread overview]
Message-ID: <alpine.DEB.2.00.1107202036130.2847@tiger> (raw)
In-Reply-To: <alpine.DEB.2.00.1107200857350.32737@router.home>
On Wed, 20 Jul 2011, Christoph Lameter wrote:
> On Wed, 20 Jul 2011, Pekka Enberg wrote:
>
>>> +++ linux-3.0-next/mm/slab.c
>>> @@ -3153,12 +3153,9 @@ static void *cache_alloc_debugcheck_afte
>>> objp += obj_offset(cachep);
>>> if (cachep->ctor && cachep->flags & SLAB_POISON)
>>> cachep->ctor(objp);
>>> -#if ARCH_SLAB_MINALIGN
>>> - if ((u32)objp & (ARCH_SLAB_MINALIGN-1)) {
>>> + if (ARCH_SLAB_MINALIGN && ((u32)objp & (ARCH_SLAB_MINALIGN-1)))
>>> printk(KERN_ERR "0x%p: not aligned to
>>> ARCH_SLAB_MINALIGN=%d\n",
>>> objp, ARCH_SLAB_MINALIGN);
>>> - }
>>> -#endif
>>> return objp;
>>
>> Looks good to me. Christoph?
>
> Looks okay but I thought you already had a patch that took out the #if
> there?
Indeed. Tetsuo, it's commit c225150 ("slab: fix DEBUG_SLAB build") in
slab.git. It should appear in linux-next soon.
Pekka
next prev parent reply other threads:[~2011-07-20 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 3:19 Tetsuo Handa
2011-07-20 13:16 ` Pekka Enberg
2011-07-20 13:58 ` Christoph Lameter
2011-07-20 17:37 ` Pekka Enberg [this message]
2011-07-21 0:42 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1107202036130.2847@tiger \
--to=penberg@kernel.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®