From: Pekka Enberg <penberg@kernel.org>
To: Kevin Wolf <kwolf@redhat.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
levinsasha928@gmail.com, tglx@linutronix.de,
linux-tip-commits@vger.kernel.org,
kvm-devel <kvm@vger.kernel.org>
Subject: Re: [tip:tools/kvm] kvm tools, qcow: Fix copy-on-write image corruption
Date: Fri, 22 Jul 2011 11:21:09 +0300 (EEST) [thread overview]
Message-ID: <alpine.DEB.2.00.1107221118380.2996@tiger> (raw)
In-Reply-To: <4E27DEA9.20404@redhat.com>
On Thu, 21 Jul 2011, Kevin Wolf wrote:
> Hm, I must have missed this patch on the KVM mailing list...
It wasn't on the list, sorry.
> You should also error out before creating a new L2 table as its refcount
> would have to be updated, too. On the other hand, the patch is a bit too
> restrictive, because it applies the check to qcow1 which doesn't even
> have a refcount table.
Oh, right, I broken QCOW1.
> I'm not sure if everyone is aware of it, so another hint: Now that you
> can't grow qcow2 any more, you might find it useful to use qemu-img
> create -f qcow2 -o preallocation=metadata, so that all clusters are
> already present and you don't get random failures.
Yup, I'm aware that you can't grow images anymore. The patch was meant as
a stop-gap measure while I'm hacking on refcount table support.
Pekka
next prev parent reply other threads:[~2011-07-22 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-4839bcd6b04a1b628f0f00d535ddca2ee872e9fa@git.kernel.org>
2011-07-21 8:09 ` Kevin Wolf
2011-07-22 8:21 ` Pekka Enberg [this message]
2011-07-22 8:33 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1107221118380.2996@tiger \
--to=penberg@kernel.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®