From: Christoph Lameter <cl@linux.com>
To: David Rientjes <rientjes@google.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
Andi Kleen <andi@firstfloor.org>,
tj@kernel.org, Metathronius Galabant <m.galabant@googlemail.com>,
Matt Mackall <mpm@selenic.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Adrian Drzewiecki <z@drze.net>,
linux-kernel@vger.kernel.org
Subject: Re: [slub p3 0/7] SLUB: [RFC] Per cpu partial lists V3
Date: Tue, 2 Aug 2011 09:10:46 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1108020909100.18524@router.home> (raw)
In-Reply-To: <alpine.DEB.2.00.1108012112420.7373@chino.kir.corp.google.com>
On Mon, 1 Aug 2011, David Rientjes wrote:
>
> This applied nicely to Linus' tree so I've moved to testing atop that
> rather than slub/lockless on the same netperf testing environment as the
> slab vs. slub comparison. The benchmarking completed without error and
> here are the results:
>
> threads before after
> 16 75509 75443 (-0.1%)
> 32 118121 117558 (-0.5%)
> 48 149997 149514 (-0.3%)
> 64 185216 186772 (+0.8%)
> 80 221195 222612 (+0.6%)
> 96 239732 241089 (+0.6%)
> 112 261967 266643 (+1.8%)
> 128 272946 281794 (+3.2%)
> 144 279202 289421 (+3.7%)
> 160 285745 297216 (+4.0%)
>
> So the patchset certainly looks helpful, especially if it improves other
> benchmarks as well.
The problem is that the partial approach has not been fine tuned yet for
these larger loads. And the proper knobs are not implemented yet.
> I'll review the patches individually, starting with the cleanup patches
> that can hopefully be pushed quickly while we discuss per-cpu partial
> lists further.
I am currently reworking the patches to operate on a linked list instead
of a very small array of pointers to page structs. That will allow much
larger per cpu partial lists and a dynamic configuration of the sizes.
next prev parent reply other threads:[~2011-08-02 14:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 16:28 Christoph Lameter
2011-08-01 16:28 ` [slub p3 1/7] slub: free slabs without holding locks (V2) Christoph Lameter
2011-08-01 16:28 ` [slub p3 2/7] slub: Remove useless statements in __slab_alloc Christoph Lameter
2011-08-01 16:28 ` [slub p3 3/7] slub: Prepare inuse field in new_slab() Christoph Lameter
2011-08-01 16:28 ` [slub p3 4/7] slub: pass kmem_cache_cpu pointer to get_partial() Christoph Lameter
2011-08-01 16:28 ` [slub p3 5/7] slub: return object pointer from get_partial() / new_slab() Christoph Lameter
2011-08-01 16:28 ` [slub p3 6/7] slub: per cpu cache for partial pages Christoph Lameter
2011-08-02 17:24 ` Christoph Lameter
2011-08-01 16:28 ` [slub p3 7/7] slub: update slabinfo tools to report per cpu partial list statistics Christoph Lameter
2011-08-02 4:15 ` [slub p3 0/7] SLUB: [RFC] Per cpu partial lists V3 David Rientjes
2011-08-02 14:10 ` Christoph Lameter [this message]
2011-08-02 16:37 ` David Rientjes
2011-08-02 16:47 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1108020909100.18524@router.home \
--to=cl@linux.com \
--cc=andi@firstfloor.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.galabant@googlemail.com \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=z@drze.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®