From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
Ian Campbell <Ian.Campbell@eu.citrix.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH v3 1/2] xen: add an "highmem" parameter to alloc_xenballooned_pages
Date: Thu, 8 Sep 2011 13:46:52 +0100 [thread overview]
Message-ID: <alpine.DEB.2.00.1109081346160.12963@kaball-desktop> (raw)
In-Reply-To: <4E67A377.3090004@goop.org>
On Wed, 7 Sep 2011, Jeremy Fitzhardinge wrote:
> > diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
> > index f914b26..07a56c2 100644
> > --- a/drivers/xen/gntdev.c
> > +++ b/drivers/xen/gntdev.c
> > @@ -123,7 +123,7 @@ static struct grant_map *gntdev_alloc_map(struct gntdev_priv *priv, int count)
> > NULL == add->pages)
> > goto err;
> >
> > - if (alloc_xenballooned_pages(count, add->pages))
> > + if (alloc_xenballooned_pages(count, add->pages, 0 /* lowmem */))
>
> If the parameter is "bool" you should pass true/false. But it might be
> better to just make it take a GFP_ constant directly.
I would rather have a bool to be consistent with the other balloon
interfaces.
next prev parent reply other threads:[~2011-09-08 12:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 16:38 [PATCH v3 0/2] xen: modify kernel mappings corresponding to granted pages Stefano Stabellini
2011-09-07 16:39 ` [PATCH v3 1/2] xen: add an "highmem" parameter to alloc_xenballooned_pages stefano.stabellini
2011-09-07 17:01 ` Jeremy Fitzhardinge
2011-09-08 12:46 ` Stefano Stabellini [this message]
2011-09-07 16:39 ` [PATCH v3 2/2] xen: modify kernel mappings corresponding to granted pages stefano.stabellini
2011-09-07 17:13 ` Jeremy Fitzhardinge
2011-09-07 17:38 ` Stefano Stabellini
2011-09-07 19:05 ` Jeremy Fitzhardinge
2011-09-07 22:27 ` Konrad Rzeszutek Wilk
2011-09-08 12:56 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1109081346160.12963@kaball-desktop \
--to=stefano.stabellini@eu.citrix.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®