From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932439Ab1ISVy7 (ORCPT ); Mon, 19 Sep 2011 17:54:59 -0400 Received: from smtp106.prem.mail.ac4.yahoo.com ([76.13.13.45]:44232 "HELO smtp106.prem.mail.ac4.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755133Ab1ISVy6 (ORCPT ); Mon, 19 Sep 2011 17:54:58 -0400 X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: JxFOykMVM1lbLinmh9QuK76f3BAsnjBfOG_clMhj65COczV Zh2uw.xKsBhTNtvrWJHQf30UkQxa7oQxk6f6TTSLco1ThSpZOdZCTfRs8iqs Uxah45OzC1f_LeW8FFyayABDzzzUUpBbHsBRrmkgA.kxQhnL8Q58GrI97WcG _H1yQowIsPY4vYIbsuXy3NgrSSVhvdXOfeKcMBnG6f6jIuQk66jOndm6wYrp .TBPE9K945g3h2KFqJRnctTncHDSbyp5HDjiMmD7YRWvKERR_x1tnXq8aFFW 3G8zT_PlwhqAySmvIYJH.i1lDaemShC5eUFXqzibL21naQnBjGBLLQO90dB1 gwa6eCWoWbsijUup8CezPffjNuKgIl9nAQ_J61xvhCZvpHNA- X-Yahoo-SMTP: _Dag8S.swBC1p4FJKLCXbs8NQzyse1SYSgnAbY0- Date: Mon, 19 Sep 2011 16:54:55 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@router.home To: Steven Rostedt cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Thomas Gleixner , Peter Zijlstra , Christoph Lameter Subject: Re: [RFC][PATCH 4/5] printk: Have wake_up_klogd() use __this_cpu_write() In-Reply-To: <20110919212641.302263742@goodmis.org> Message-ID: References: <20110919212040.745370781@goodmis.org> <20110919212641.302263742@goodmis.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Sep 2011, Steven Rostedt wrote: > From: Steven Rostedt > > The wake up code that triggers klogd does not really matter which > CPU it enables the wake up on. Every CPU will be doing a printk_tick() > and check the current CPU. As long as one of the CPUs triggers the > wakeup we are fine. Use __this_cpu_write() instead of this_cpu_write() > to show that we do not care. printk_needs_cpu() is always called from context where we have disabled interrupts therefore this is safe to do. Reviewed-by: Christoph Lameter