From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: Kevin Hilman <khilman@ti.com>,
Grant Likely <grant.likely@secretlab.ca>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
tony@atomide.com
Subject: Re: [PATCH 3.1-rc3] gpio/omap: fix build error with certain OMAP1 configs
Date: Tue, 11 Oct 2011 00:12:45 +0300 (EEST) [thread overview]
Message-ID: <alpine.DEB.2.00.1110102356530.7624@dell> (raw)
In-Reply-To: <201110071430.14420.jkrzyszt@tis.icnet.pl>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1375 bytes --]
Hi,
On Fri, 7 Oct 2011, Janusz Krzysztofik wrote:
> Dnia wtorek, 23 sierpnia 2011 o 19:11:47 Kevin Hilman napisał(a):
>> Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> writes:
>>> With commit f64ad1a0e21a, "gpio/omap: cleanup _set_gpio_wakeup(), remove
>>> ifdefs", access to build time conditionally omitted 'suspend_wakeup'
>>> member of the 'gpio_bank' structure has been placed unconditionally in
>>> function _set_gpio_wakeup(), which is always built. This resulted in the
>>> driver compilation broken for certain OMAP1, i.e., non-OMAP16xx,
>>> configurations.
>>>
>>> Really required or not in previously excluded cases, define this
>>> structure member unconditionally as a fix.
>>>
>>> Tested with a custom OMAP1510 only configuration.
>>>
>>> Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
>>
>> Verified that this fixes a build problem when building for OMAP1
>> (730/850 only)
>>
>> Acked-by: Kevin Hilman <khilman@ti.com>
Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>> Grant, can you queue this as a fix for 3.1-rc?
>
> Sorry for being so late with checking this, but it looks like this patch
> never got into 3.1-rc, as it should, leaving the issue not fixed.
> Any chance for it still being pushed into 3.1?
This patch is one-liner, and still needed to get 3.1-rc9 compiled and
running on e.g. Amstrad E3, so I think it should get into 3.1.
A.
next prev parent reply other threads:[~2011-10-10 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 11:42 Janusz Krzysztofik
2011-08-23 17:11 ` Kevin Hilman
2011-10-07 12:30 ` Janusz Krzysztofik
2011-10-10 21:12 ` Aaro Koskinen [this message]
[not found] ` <87fwiz8okk.fsf@ti.com>
2011-10-13 17:42 ` Grant Likely
2011-10-13 17:47 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1110102356530.7624@dell \
--to=aaro.koskinen@iki.fi \
--cc=grant.likely@secretlab.ca \
--cc=jkrzyszt@tis.icnet.pl \
--cc=khilman@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®