From: David Rientjes <rientjes@google.com>
To: Joe Perches <joe@perches.com>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
linux-kernel@vger.kernel.org, Jonathan Cameron <jic23@cam.ac.uk>,
Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] checkpatch: improve error message for p1-check
Date: Thu, 27 Oct 2011 13:11:15 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1110271309050.7639@chino.kir.corp.google.com> (raw)
In-Reply-To: <1319672648.21924.26.camel@Joe-Laptop>
On Wed, 26 Oct 2011, Joe Perches wrote:
> > I mean it only makes sense if both prefixes exist (otherwise patch and
> > git-apply will assume it's not a -p0 patch).
>
> I think we should not care about the prefixes at all,
> only whether or not the patched file exists.
>
Nack, there's nothing wrong with storing original files that you're
modifying in a subdirectory with a name of your choice in the kernel tree.
It doesn't imply a -p0 patch unless both prefixes appear and that's the
best indication that it appears in both the patch author and patch
applier's tree whereas the file being modified is ambiguous.
next prev parent reply other threads:[~2011-10-27 20:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 12:33 Wolfram Sang
2011-10-26 20:30 ` David Rientjes
2011-10-26 22:51 ` Joe Perches
2011-10-26 23:08 ` David Rientjes
2011-10-26 23:14 ` Joe Perches
2011-10-26 23:34 ` David Rientjes
2011-10-26 23:44 ` Joe Perches
2011-10-27 20:11 ` David Rientjes [this message]
2011-10-27 20:29 ` Joe Perches
2011-10-27 21:01 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1110271309050.7639@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=apw@canonical.com \
--cc=jic23@cam.ac.uk \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®