From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933113Ab1KJUuM (ORCPT ); Thu, 10 Nov 2011 15:50:12 -0500 Received: from mail-dy0-f46.google.com ([209.85.220.46]:63075 "EHLO mail-dy0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752982Ab1KJUuI (ORCPT ); Thu, 10 Nov 2011 15:50:08 -0500 Date: Thu, 10 Nov 2011 12:50:01 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Mandeep Singh Baines , Dave Airlie cc: linux-kernel@vger.kernel.org, David Airlie , Hugh Dickins , Hugh Dickins , Andrew Morton , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: avoid switching to text console if there is no panic timeout In-Reply-To: Message-ID: References: <1318896400-32498-1-git-send-email-msb@chromium.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Oct 2011, David Rientjes wrote: > On Mon, 17 Oct 2011, Mandeep Singh Baines wrote: > > > From: Hugh Dickins > > > > Add a check for panic_timeout in the drm_fb_helper_panic() notifier: if > > we're going to reboot immediately, the user will not be able to see the > > messages anyway, and messing with the video mode may display artifacts, > > and certainly get into several layers of complexity (including mutexes and > > memory allocations) which we shall be much safer to avoid. > > > > Signed-off-by: Hugh Dickins > > [ Edited commit message and modified to short-circuit panic_timeout < 0 > > instead of testing panic_timeout >= 0. -Mandeep ] > > Signed-off-by: Mandeep Singh Baines > > Cc: Dave Airlie > > Cc: Andrew Morton > > Cc: dri-devel@lists.freedesktop.org > > Acked-by: David Rientjes > Dave, where do we stand on this? I haven't seen it hit Linus' tree and I don't see it in git://people.freedesktop.org/~airlied/linux.