From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753011Ab2C1HTi (ORCPT ); Wed, 28 Mar 2012 03:19:38 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:50886 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580Ab2C1HTh (ORCPT ); Wed, 28 Mar 2012 03:19:37 -0400 Date: Wed, 28 Mar 2012 00:19:34 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Borislav Petkov cc: LKML , Borislav Petkov , Andi Kleen , linux-mm@kvack.org Subject: Re: [PATCH] mm/memory_failure: Let the compiler add the function name In-Reply-To: <1332843450-7100-1-git-send-email-bp@amd64.org> Message-ID: References: <1332843450-7100-1-git-send-email-bp@amd64.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Mar 2012, Borislav Petkov wrote: > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 56080ea36140..7d78d5ec61a7 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1384,16 +1384,16 @@ static int get_any_page(struct page *p, unsigned long pfn, int flags) > */ > if (!get_page_unless_zero(compound_head(p))) { > if (PageHuge(p)) { > - pr_info("get_any_page: %#lx free huge page\n", pfn); > + pr_info("%s: %#lx free huge page\n", __func__, pfn); > ret = dequeue_hwpoisoned_huge_page(compound_head(p)); > } else if (is_free_buddy_page(p)) { > - pr_info("get_any_page: %#lx free buddy page\n", pfn); > + pr_info("%s: %#lx free buddy page\n", __func__, pfn); > /* Set hwpoison bit while page is still isolated */ > SetPageHWPoison(p); > ret = 0; > } else { > - pr_info("get_any_page: %#lx: unknown zero refcount page type %lx\n", > - pfn, p->flags); > + pr_info("%s: %#lx: unknown zero refcount page type %lx\n", > + __func__, pfn, p->flags); > ret = -EIO; > } > } else { I agree with your change, but I'm not sure these should be pr_info() to start with, these seem more like debugging messages? I can't see how they'd be useful in standard operation so could we just convert them to be debug instead?