From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751259Ab2JPECu (ORCPT ); Tue, 16 Oct 2012 00:02:50 -0400 Received: from mail-da0-f46.google.com ([209.85.210.46]:56973 "EHLO mail-da0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277Ab2JPECs (ORCPT ); Tue, 16 Oct 2012 00:02:48 -0400 Date: Mon, 15 Oct 2012 21:02:45 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Glauber Costa , Andrew Morton cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Lameter , Mel Gorman Subject: Re: [PATCH] make GFP_NOTRACK flag unconditional In-Reply-To: Message-ID: References: <1348826194-21781-1-git-send-email-glommer@parallels.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Oct 2012, David Rientjes wrote: > > There was a general sentiment in a recent discussion (See > > https://lkml.org/lkml/2012/9/18/258) that the __GFP flags should be > > defined unconditionally. Currently, the only offender is GFP_NOTRACK, > > which is conditional to KMEMCHECK. > > > > This simple patch makes it unconditional. > > > > Signed-off-by: Glauber Costa > > CC: Christoph Lameter > > CC: Mel Gorman > > CC: Andrew Morton > > Acked-by: David Rientjes > > I think it was done this way to show that if CONFIG_KMEMCHECK=n then the > bit could be reused for something else but I can't think of any reason why > that would be useful; what would need to add a gfp bit that would also > happen to depend on CONFIG_KMEMCHECK=n? Nothing comes to mind to save a > bit. > > There are other cases of this as well, like __GFP_OTHER_NODE which is only > useful for thp and it's defined unconditionally. So this seems fine to > me. > Still missing from linux-next as of this morning, I think this patch should be merged.