From: David Rientjes <rientjes@google.com>
To: Eilon Greenstein <eilong@broadcom.com>
Cc: Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: add double empty line check
Date: Fri, 16 Nov 2012 11:55:04 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1211161154280.2788@chino.kir.corp.google.com> (raw)
In-Reply-To: <1353094919.14327.4.camel@lb-tlvb-eilong.il.broadcom.com>
On Fri, 16 Nov 2012, Eilon Greenstein wrote:
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 21a9f5d..7a9c153 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3579,6 +3579,13 @@ sub process {
> WARN("EXPORTED_WORLD_WRITABLE",
> "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
> }
> +
> +# check for double empty lines
> + if ($line =~ /^\+\s*$/ &&
> + ($prevline =~ /^\+?\s*$/ || $rawlines[$linenr] =~ /^\s*$/)) {
> + WARN("DOUBLE_EMPTY_LINE",
> + "One empty line should be sufficient. Consider removing this one.\n" . $herecurr);
> + }
> }
>
> # If we have no input at all, then there is nothing to report on
This is fairly common in all the acpi code where variables declared in a
function are separated from the code in a function.
next prev parent reply other threads:[~2012-11-16 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 19:41 Eilon Greenstein
2012-11-16 19:55 ` David Rientjes [this message]
2012-11-16 20:04 ` Eilon Greenstein
2012-11-17 0:50 ` Joe Perches
2012-11-17 11:12 ` Eilon Greenstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1211161154280.2788@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=apw@canonical.com \
--cc=eilong@broadcom.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®