mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Doug Anderson <dianders@chromium.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Shaohua Li <shli@kernel.org>,
	Jens Axboe <axboe@kernel.dk>, Neil Brown <neilb@suse.de>,
	Tejun Heo <tj@kernel.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>
Subject: Re: [PATCH] block: Avoid divide by 0 when max_discard_sectors is 0
Date: Tue, 18 Dec 2012 16:42:04 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1212181641050.3932@chino.kir.corp.google.com> (raw)
In-Reply-To: <1355876729-25627-1-git-send-email-dianders@chromium.org>

On Tue, 18 Dec 2012, Doug Anderson wrote:

> The recent commit "block: discard granularity might not be power of 2"
> introduced a divide by 0 in the kernel.  Previously the code didn't
> try to divide by discard_granularity when max_discard_sectors was 0.
> 
> Fix the code to only do the division if max_discard_sectors is
> specified.
> 

Could you try Linus' patch at 
http://marc.info/?l=linux-kernel&m=135584941732572 and give your Tested-by 
if it solves your issue?

Thanks.

  reply	other threads:[~2012-12-19  0:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-19  0:25 Doug Anderson
2012-12-19  0:42 ` David Rientjes [this message]
2012-12-19  1:02   ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1212181641050.3932@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=axboe@kernel.dk \
    --cc=dianders@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=neilb@suse.de \
    --cc=shli@kernel.org \
    --cc=snitzer@redhat.com \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®