From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756703AbbI2PEO (ORCPT ); Tue, 29 Sep 2015 11:04:14 -0400 Received: from 78-80-28-91.tmcz.cz ([78.80.28.91]:55066 "EHLO leontynka.twibright.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754154AbbI2PED (ORCPT ); Tue, 29 Sep 2015 11:04:03 -0400 Date: Tue, 29 Sep 2015 17:03:24 +0200 (CEST) From: Mikulas Patocka X-X-Sender: mikulas@leontynka To: Yaowei Bai cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/17] fs/hpfs: remove unnecessary new_valid_dev check In-Reply-To: <1443449479-5379-1-git-send-email-bywxiaobai@163.com> Message-ID: References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> <1443449479-5379-1-git-send-email-bywxiaobai@163.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi I suppose that you should remove the function new_valid_dev at all. Mikulas On Mon, 28 Sep 2015, Yaowei Bai wrote: > As new_valid_dev always returns 1, so !new_valid_dev check is not > needed, remove it. > > Signed-off-by: Yaowei Bai > --- > fs/hpfs/namei.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/hpfs/namei.c b/fs/hpfs/namei.c > index 9e92c9c..ae4d5a1 100644 > --- a/fs/hpfs/namei.c > +++ b/fs/hpfs/namei.c > @@ -227,8 +227,6 @@ static int hpfs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode, de > int err; > if ((err = hpfs_chk_name(name, &len))) return err==-ENOENT ? -EINVAL : err; > if (hpfs_sb(dir->i_sb)->sb_eas < 2) return -EPERM; > - if (!new_valid_dev(rdev)) > - return -EINVAL; > hpfs_lock(dir->i_sb); > err = -ENOSPC; > fnode = hpfs_alloc_fnode(dir->i_sb, hpfs_i(dir)->i_dno, &fno, &bh); > -- > 1.9.1 > > >