From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757001AbbJAUuJ (ORCPT ); Thu, 1 Oct 2015 16:50:09 -0400 Received: from 78-80-28-91.tmcz.cz ([78.80.28.91]:55378 "EHLO leontynka.twibright.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752284AbbJAUuI (ORCPT ); Thu, 1 Oct 2015 16:50:08 -0400 Date: Thu, 1 Oct 2015 22:49:41 +0200 (CEST) From: Mikulas Patocka X-X-Sender: mikulas@leontynka To: Yaowei Bai cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/17] fs/hpfs: remove unnecessary new_valid_dev check In-Reply-To: <20150930111330.GA3006@bbox> Message-ID: References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> <1443449479-5379-1-git-send-email-bywxiaobai@163.com> <20150930111330.GA3006@bbox> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Sep 2015, Yaowei Bai wrote: > On Tue, Sep 29, 2015 at 05:03:24PM +0200, Mikulas Patocka wrote: > > Hi > > > > I suppose that you should remove the function new_valid_dev at all. > > Yes, i thought about that, but actually there's still a user of > new_valid_dev in fs/stat.c: > > #define valid_dev(x) choose_32_64(old_valid_dev,new_valid_dev)(x) > > so i just left new_valid_dev untouched and removed other users in fs first. So, remove that too - change it to choose_32_64(old_valid_dev(x),true) If you remove most calls for the function new_valid_dev, the function is meaningless and shouldn't be present in the source code. Mikulas