From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752343AbcLERWz (ORCPT ); Mon, 5 Dec 2016 12:22:55 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:62126 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751977AbcLERWy (ORCPT ); Mon, 5 Dec 2016 12:22:54 -0500 Date: Mon, 5 Dec 2016 17:22:41 +0000 From: "Maciej W. Rozycki" To: Matt Redfearn CC: Ralf Baechle , , "Jason A . Donenfeld" , Thomas Gleixner , , James Hogan , Paul Burton Subject: Re: [PATCH 3/5] MIPS: Only change $28 to thread_info if coming from user mode In-Reply-To: <9579f0c6-9f67-cf1d-94c1-34d14f38afd6@imgtec.com> Message-ID: References: <1480685957-18809-1-git-send-email-matt.redfearn@imgtec.com> <1480685957-18809-4-git-send-email-matt.redfearn@imgtec.com> <9579f0c6-9f67-cf1d-94c1-34d14f38afd6@imgtec.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [10.20.78.176] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Dec 2016, Matt Redfearn wrote: > Ah yes, I missed the .set reorder above the EVA ifdef and just included the > .set reorder as the similar snippet here: > http://lxr.free-electrons.com/source/arch/mips/include/asm/stackframe.h#L149 That's a global `.set reorder' for the whole of SAVE_SOME, just as I suggested for all the macros here. Then a temporary `.set noreorder' override follows just for the manually scheduled BLTZ/MOVE sequence, where someone has later inserted a whole CONFIG_EVA block. As I noted this temporary override is unnecessary. Incidentally it does not harm the CONFIG_EVA block either, because EVA processors have MFC0 interlocked. NB I think the MFC0 macro ought to be called REG_MFC0, to avoid confusion and for consistency with the rest of such macros. Maciej