From: "Maciej W. Rozycki" <macro@imgtec.com>
To: Matt Redfearn <matt.redfearn@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, <linux-mips@linux-mips.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Thomas Gleixner <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>,
James Hogan <james.hogan@imgtec.com>,
Paul Burton <paul.burton@imgtec.com>
Subject: Re: [PATCH v2 3/5] MIPS: Only change $28 to thread_info if coming from user mode
Date: Thu, 15 Dec 2016 11:51:54 +0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1612150120400.6743@tp.orcam.me.uk> (raw)
In-Reply-To: <1481626745-4290-4-git-send-email-matt.redfearn@imgtec.com>
On Tue, 13 Dec 2016, Matt Redfearn wrote:
> diff --git a/arch/mips/include/asm/stackframe.h b/arch/mips/include/asm/stackframe.h
> index eebf39549606..e13164daf9c2 100644
> --- a/arch/mips/include/asm/stackframe.h
> +++ b/arch/mips/include/asm/stackframe.h
> @@ -216,12 +216,20 @@
> LONG_S $25, PT_R25(sp)
> LONG_S $28, PT_R28(sp)
> LONG_S $31, PT_R31(sp)
> +
> + /* Set thread_info if we're coming from user mode */
> + mfc0 k0, CP0_STATUS
> + sll k0, 3 /* extract cu0 bit */
> + bltz k0, 9f
> + nop
> +
Have you actually verified the machine code generated as expected with
such a change? This supposedly delay-slot NOP can be dropped as this is
`.set reorder' code, so GAS will have scheduled a NOP itself already,
having found there is an SLL->BLTZ data dependency and consequently the
two instructions cannot be swapped. So now there'll be an extraneous NOP
there, wasting code space and execution time.
Maciej
next prev parent reply other threads:[~2016-12-15 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 10:59 [PATCH v2 0/5] MIPS: Add per-cpu IRQ stack Matt Redfearn
2016-12-13 10:59 ` [PATCH v2 1/5] MIPS: Introduce irq_stack Matt Redfearn
2016-12-13 10:59 ` [PATCH v2 2/5] MIPS: Stack unwinding while on IRQ stack Matt Redfearn
2016-12-13 10:59 ` [PATCH v2 3/5] MIPS: Only change $28 to thread_info if coming from user mode Matt Redfearn
2016-12-15 11:51 ` Maciej W. Rozycki [this message]
2016-12-13 10:59 ` [PATCH v2 4/5] MIPS: Switch to the irq_stack in interrupts Matt Redfearn
2016-12-13 10:59 ` [PATCH v2 5/5] MIPS: Select HAVE_IRQ_EXIT_ON_IRQ_STACK Matt Redfearn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1612150120400.6743@tp.orcam.me.uk \
--to=macro@imgtec.com \
--cc=Jason@zx2c4.com \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=matt.redfearn@imgtec.com \
--cc=paul.burton@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®