From: "Maciej W. Rozycki" <macro@mips.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: <linux-mips@linux-mips.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ralf Baechle <ralf@linux-mips.org>,
"Kevin Cernekee" <cernekee@gmail.com>,
James Hogan <jhogan@kernel.org>,
Paul Burton <paul.burton@mips.com>,
Matt Redfearn <matt.redfearn@mips.com>,
Huacai Chen <chenhc@lemote.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Marcin Nowakowski <marcin.nowakowski@mips.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Ingo Molnar <mingo@kernel.org>,
David Howells <dhowells@redhat.com>,
Kees Cook <keescook@chromium.org>, Thomas Meyer <thomas@m3y3r.de>,
Bryan O'Donoghue <pure.logic@nexus-software.ie>,
Robin Murphy <robin.murphy@arm.com>,
"Michal Hocko" <mhocko@suse.com>,
Lucas Stach <l.stach@pengutronix.de>,
"Vladimir Murzin" <vladimir.murzin@arm.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC 3/6] MIPS: BMIPS: Avoid referencing CKSEG1
Date: Fri, 2 Feb 2018 17:38:00 +0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1802012034400.4191@tp.orcam.me.uk> (raw)
In-Reply-To: <1516758426-8127-4-git-send-email-f.fainelli@gmail.com>
On Tue, 23 Jan 2018, Florian Fainelli wrote:
> bmips_smp_movevec() references the CKSEG1 constant, which is about to be
> updated in order to support processors that might enable eXtended
> KSEG0/1. In doing so, we will generate a reference to a function, which
> is obviously not permissible within assembly. Fortunately,
> bmips_smp_movevec() is only used on BMIPS4350 which does not support
> eXtended KSEG0/1.
Can you please avoid replacing the macro with a hardcoded magic number
though, so that it retains the high-level meaning?
Define another macro, say MIPS_ARCH_CKSEG1, and use it here instead, and
possibly elsewhere too. You could complement it with BMIPS_XKS01_CKSEG1
if necessary too (I haven't thoroughly looked through your patches).
Maciej
next prev parent reply other threads:[~2018-02-02 17:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 1:47 [PATCH RFC 0/6] MIPS: Broadcom eXtended KSEG0/1 support Florian Fainelli
2018-01-24 1:47 ` [PATCH RFC 1/6] MIPS: Allow board to override TLB initialization Florian Fainelli
2018-01-24 1:47 ` [PATCH RFC 2/6] MIPS: Allow platforms to override mapping/unmapping coherent Florian Fainelli
2018-01-24 1:47 ` [PATCH RFC 3/6] MIPS: BMIPS: Avoid referencing CKSEG1 Florian Fainelli
2018-02-02 17:38 ` Maciej W. Rozycki [this message]
2018-01-24 1:47 ` [PATCH RFC 4/6] MIPS: Prepare for supporting eXtended KSEG0/1 Florian Fainelli
2018-01-24 1:47 ` [PATCH RFC 5/6] MIPS: BMIPS: Handshake with CFE Florian Fainelli
2018-01-24 1:47 ` [PATCH RFC 6/6] MIPS: BMIPS: Add support for eXtended KSEG0/1 (XKS01) Florian Fainelli
2018-01-26 8:31 ` [PATCH RFC 0/6] MIPS: Broadcom eXtended KSEG0/1 support Steven J. Hill
2018-01-29 20:10 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1802012034400.4191@tp.orcam.me.uk \
--to=macro@mips.com \
--cc=akpm@linux-foundation.org \
--cc=bart.vanassche@sandisk.com \
--cc=cernekee@gmail.com \
--cc=chenhc@lemote.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhogan@kernel.org \
--cc=keescook@chromium.org \
--cc=kstewart@linuxfoundation.org \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=marcin.nowakowski@mips.com \
--cc=matt.redfearn@mips.com \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=paul.burton@mips.com \
--cc=pure.logic@nexus-software.ie \
--cc=ralf@linux-mips.org \
--cc=robin.murphy@arm.com \
--cc=thomas@m3y3r.de \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®