From: Peter Meerwald <p.meerwald@bct-electronic.com>
To: Bryan Wu <cooloney@gmail.com>
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] leds-pca9633: Add support for PCA9634
Date: Fri, 9 Aug 2013 00:36:22 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.01.1308090013440.21412@pmeerw.net> (raw)
In-Reply-To: <CAK5ve-+nnAGAnFNb6=QuekDMQwJ7w7h7k67dES0=wTN07n-9NA@mail.gmail.com>
Hello,
> > Add support for PCA9634 chip, which belongs to the same family as the
> > 9633 but with support for 8 outputs instead of 4.
> Basically I like this method to add a new chip supporting. Please find
> my comments below.
me too :)
> What about just rename the whole file to leds-pca963x.c. And rename
> some pca9633 to pca963x in the driver.
there are other, similar I2C LED driver chips which might be
handled with the current pca9633 driver, e.g. the pca9685 (which is
supported under pwm/ by the way)
people have argued that the numbering scheme of chips is hard to
predict; hence, the driver name should be determined by the first
device supported to avoid subsequent renaming -- but I have no strong
feelings about this
regards, p.
--
Peter Meerwald
+43-664-2444418 (mobile)
next prev parent reply other threads:[~2013-08-08 22:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 16:45 [PATCH v2 0/3] PCA9633: Add support to PCA9634 and fix some problems Ricardo Ribalda Delgado
2013-08-08 16:45 ` [PATCH v2 1/3] leds-pca9633: Add support for PCA9634 Ricardo Ribalda Delgado
2013-08-08 22:09 ` Bryan Wu
2013-08-08 22:36 ` Peter Meerwald [this message]
2013-08-08 22:49 ` Bryan Wu
2013-08-09 6:43 ` Ricardo Ribalda Delgado
2013-08-08 16:45 ` [PATCH v2 2/3] leds-pca9633: Unique naming of the LEDs Ricardo Ribalda Delgado
2013-08-08 22:12 ` Bryan Wu
2013-08-08 16:45 ` [PATCH v2 3/3] leds-pca9633: Add mutex to the ledout register Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.01.1308090013440.21412@pmeerw.net \
--to=p.meerwald@bct-electronic.com \
--cc=cooloney@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®